enhance: Limit DevToolsManager action buffer depth to 100

reactive · Jan 18, 2024 · 4e6a39e · 4e6a39e
1 parent 8535c6c
commit 4e6a39e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/.changeset/shiny-maps-double.md b/.changeset/shiny-maps-double.md
@@ -0,0 +1,7 @@
+---
+"@data-client/core": patch
+---
+
+Limit DevToolsManager action buffer depth to 100
+
+This will avoid memory leaks in long running applications, or ones with frequent updates.
diff --git a/packages/core/src/manager/DevtoolsManager.ts b/packages/core/src/manager/DevtoolsManager.ts
@@ -82,6 +82,7 @@ export default class DevToolsManager implements Manager {
   protected started = false;
   protected actions: [ActionTypes, State<unknown>][] = [];
   protected declare controller: Controller;
+  maxBufferLength = 100;
 
   constructor(
     config?: DevToolsConfig,
@@ -151,6 +152,10 @@ export default class DevToolsManager implements Manager {
     if (this.started) {
       this.devTools.send(action, state, undefined, 'RDC');
     } else {
+      // avoid this getting too big in case this is long running
+      // we cut in half so we aren't constantly reallocating
+      if (this.actions.length > this.maxBufferLength)
+        this.actions = this.actions.slice(this.maxBufferLength / 2);
       // queue actions
       this.actions.push([action, state]);
     }