Link Django CSS to components (CSS Modules) #227
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, styles can only loosely be tied to components via CSS. This PR allows ReactPy to parse a CSS file and apply the CSS rules as in-line styles.
These styles are applied server-side, so certain limitations are unavoidable. For example, there's no way for media queries to function under this architecture, since the server currently has no way to query client-side DOM properties.
It's going to be an uphill battle to develop support for all CSS psuedo-selectors (ex.
:first-child
).Some event based psuedo-selectors are going to be challenging as well (such as
:hover
). For example, event-based pseudo-selectors (such as:hover
) may need to be handled via automatically generatedhtml.script
. Would be some ugly stuff though.This PR may end up pivoting to a different design, or perhaps allow configurability between different client/server side methods of applying CSS.
fix #211
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).