Merge pull request #350 from reactioncommerce/fix-aldeed-select-clear

fix: clear Select when value prop becomes null
reactioncommerce · Oct 31, 2018 · e63cc4c · e63cc4c
2 parents 76998ac + a747deb
commit e63cc4c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/package/src/components/Select/v1/Select.js b/package/src/components/Select/v1/Select.js
@@ -573,7 +573,7 @@ class Select extends Component {
       passthroughProps[prop] = this.props[prop];
     });
 
-    let optionValue;
+    let optionValue = null;
     if (value !== undefined && value !== null) {
       optionValue = reactSelectOptions.find((opt) => {
         if (opt.options) return opt.options.find((o) => o.value === value);

diff --git a/package/src/components/Select/v1/Select.test.js b/package/src/components/Select/v1/Select.test.js
@@ -55,3 +55,11 @@ test("alphabetize option snapshot", () => {
   const tree = component.toJSON();
   expect(tree).toMatchSnapshot();
 });
+
+test("when value prop changes to `null`, selection is cleared", () => {
+  const wrapper = mount(<Select options={OPTIONS} value="c" />);
+  expect(wrapper.html().indexOf(">C</div>")).not.toBe(-1);
+
+  wrapper.setProps({ value: null });
+  expect(wrapper.html().indexOf(">Select...</div>")).not.toBe(-1);
+});