Skip to content

Commit

Permalink
Merge pull request #469 from reactioncommerce/spencer-fix-linting-issues
Browse files Browse the repository at this point in the history
fix: resolve several linting issues
  • Loading branch information
spencern authored Dec 3, 2019
2 parents aee6239 + 3a358bb commit 2eacd49
Show file tree
Hide file tree
Showing 7 changed files with 29 additions and 20 deletions.
2 changes: 2 additions & 0 deletions package/scripts/postbuild.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ async function recursivelyChangeExtension(fullDirPath, ext, newExt) {

await fse.copy(childPath, childPath.replace(`.${ext}`, `.${newExt}`));
await fse.remove(childPath);

return null;
});
await Promise.all(promises);
}
Expand Down
9 changes: 8 additions & 1 deletion package/src/components/AddressBook/v1/AddressBook.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,14 @@ class AddressBook extends Component {
// Render Methods
//
renderAccordionFormList() {
const { account: { addressBook }, addNewItemButtonText, components: { AccordionFormList, AddressForm }, deleteItemButtonText, entryFormSubmitButtonText, isSaving } = this.props;
const {
account: { addressBook },
addNewItemButtonText,
components: { AccordionFormList, AddressForm },
deleteItemButtonText,
entryFormSubmitButtonText,
isSaving
} = this.props;

const items = addressBook.map(({ _id, ...address }) => ({
id: _id,
Expand Down
14 changes: 7 additions & 7 deletions package/src/components/CartSummary/v1/CartSummary.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ class CartSummary extends Component {
* The text for the "Items" label text.
*/
itemLabelText: PropTypes.string,
/**
* The text for the "items" header text.
*/
itemsText: PropTypes.string,
/**
* Quantity of products in shopping cart
*/
itemsQuantity: PropTypes.number,
/**
* The text for the "items" header text.
*/
itemsText: PropTypes.string,
/**
* The text for the "Order total" label text.
*/
Expand All @@ -168,7 +168,7 @@ class CartSummary extends Component {
/**
* The text for the "Tax" label text.
*/
taxLabelText: PropTypes.string,
taxLabelText: PropTypes.string
}

static defaultProps = {
Expand All @@ -180,7 +180,7 @@ class CartSummary extends Component {
promoCodeText: "Promo code applied",
shippingLabelText: "Shipping",
surchargesLabelText: "Surcharges",
taxLabelText: "Tax",
taxLabelText: "Tax"
}

renderHeader() {
Expand Down Expand Up @@ -228,7 +228,7 @@ class CartSummary extends Component {
orderTotalLabelText,
shippingLabelText,
surchargesLabelText,
taxLabelText,
taxLabelText
} = this.props;

// Use "-" to indicate we are still calculating this field.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class CheckoutEmailAddress extends Component {
/**
* The text for the "Signed in as" label text.
*/
signedInText: PropTypes.string,
signedInText: PropTypes.string
};

static defaultProps = {
Expand Down
2 changes: 1 addition & 1 deletion package/src/components/Field/v1/Field.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class Field extends Component {
/**
* The text for the "Optional" label text.
*/
optionalLabelText: PropTypes.string,
optionalLabelText: PropTypes.string
};

static defaultProps = {
Expand Down
10 changes: 5 additions & 5 deletions package/src/components/MiniCartSummary/v1/MiniCartSummary.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,19 @@ class MiniCartSummary extends Component {
* The computed taxes for items in the cart.
*/
displayTax: PropTypes.string,
/**
* The text for the "Tax" label text.
*/
taxLabelText: PropTypes.string,
/**
* The text for the "Subtotal" label text.
*/
subtotalLabelText: PropTypes.string,
/**
* The text for the "Tax" label text.
*/
taxLabelText: PropTypes.string
};

static defaultProps = {
taxLabelText: "Tax",
subtotalLabelText: "Subtotal",
subtotalLabelText: "Subtotal"
}

renderTax = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@ class StripePaymentInput extends Component {
* and `amount` properties.
*/
onSubmit: PropTypes.func,
/**
* The text for the "Your Information is private and secure." caption text.
*/
secureCaptionText: PropTypes.string,
/**
* The text for the "Your Information is private and secure." caption text.
*/
secureCaptionText: PropTypes.string
};

static defaultProps = {
onReadyForSaveChange() {},
onSubmit() {},
secureCaptionText: "Your Information is private and secure.",
secureCaptionText: "Your Information is private and secure."
};

componentDidMount() {
Expand Down

0 comments on commit 2eacd49

Please sign in to comment.