Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling and messages to prevent running develop #148

Closed
wants to merge 1 commit into from
Closed

Conversation

breakerbar
Copy link
Contributor

@breakerbar breakerbar commented Oct 18, 2022

Add error handling and messages to prevent running develop while in a directory without a project already defined

solves #23

… directory without a project already defined

Signed-off-by: Matthew Palombi <[email protected]>
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breakerbar When I test this running it in a directory with a package.json I get the error:

reaction-cli: Error while parsing package.json
reaction-cli: No project type found

I also get it in a valid project

@brent-hoover
Copy link
Collaborator

@breakerbar You will also want to fix up your commit message

@breakerbar
Copy link
Contributor Author

breakerbar commented Oct 20, 2022

Taking a look - I think I know what it could be. I'm assuming that when you run develop api|admin|storefront you're in a directory that is only one of those projectType and it must be the one that matches the one in the command, is that correct?

@breakerbar
Copy link
Contributor Author

@zenweasel What is the exact command you're running and what is projectType set to in the package.json in your current directory for the invalid/valid examples?

@brent-hoover
Copy link
Collaborator

I get the same error regardless of where I run it from. Seems like it's having a problem parsing the package.json for some reason. I'm running reaction develop in every case

@breakerbar
Copy link
Contributor Author

Thanks - I can duplicate it on my side, working on it now.

@brent-hoover
Copy link
Collaborator

@breakerbar Just pinging you that Hacktober is almost over if you want to get this in

@breakerbar
Copy link
Contributor Author

thanks - I plan to get to it, but it might be later this week.

@breakerbar breakerbar closed this by deleting the head repository Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants