If you start develop in a directory that doesn't contain a project it should warn you

[brent-hoover]

Right now you just get:

 »» reaction develop api
reaction-cli: starting development on api: {"options":{}})
reaction-cli: Starting Mongo docker image
reaction-cli: Starting Open Commerce API Server in dev mode
[brent@ferret: 15:54:23 ~/Projects/merchstack/sample-data-plugin 

[breakerbar]

I'm interested in working on this bug.

[delagroove]

@breakerbar sure, you can fork the project, work on a solution and send a Pull Request which will be reviewed and merged if everything works well, remember to sign off your commits
basically adding the -S parameter: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[brent-hoover]

@breakerbar assigned this to you

[breakerbar]

thanks - working on it now

[breakerbar]

@zenweasel I'm unable to duplicate this behavior, can you provide a directory listing (or better yet a .zip/.tar.gz) of an example directory where this occurs? If I run this in the base directory of the project I get the following warning:

$ reaction develop api
reaction-cli: Developing project: {"projectType":"api","options":{"debug":true,"mongoShutdown":true}}
reaction-cli: starting development on api: {"options":{"debug":true,"mongoShutdown":true}}
reaction-cli: Starting Mongo docker image
no configuration file provided: not found
npm
ERR! Missing script: "start:dev"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/user-redacted/.npm/_logs/2022-10-14T19_25_46_677Z-debug.log

but otherwise you'd get this warning for an empty directory:

$ reaction develop api
reaction-cli: Developing project: {"projectType":"api","options":{"debug":true,"mongoShutdown":true}}
reaction-cli: It looks like you have not run `npm install` in this directory
reaction-cli: Please run `npm install` and try again

[brent-hoover]

@breakerbar both the examples you provided are examples of it being broken. It should provide you an accurate message of what is wrong and how to fix it, not irrelevant or incorrect error messages. e.g. "You are attempting to start develop but are not in a project directory. Change to a project directory or create one".

Specifically it should check for a package.json with one of the project types set.

[breakerbar]

Thank you, very helpful. Will do.

[breakerbar]

PR submitted ^

[DhanaSekharM]

Is this issue still open? I would like to work on this