Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support react 19 #1236

Merged
merged 10 commits into from
Jan 1, 2025
Merged

Conversation

anajavi
Copy link
Contributor

@anajavi anajavi commented Dec 13, 2024

  • allow react 19 in peer dependencies
  • fix building
  • make tests pass
  • had to upgrade a lot of packages to make this work

closes #1235
closes #1238

@anajavi anajavi mentioned this pull request Dec 13, 2024
1 task
@anajavi anajavi changed the title test: make tests pass feat: support react 19 Dec 19, 2024
@AlonMiz
Copy link

AlonMiz commented Dec 20, 2024

💪

@israelins85
Copy link

israelins85 commented Dec 24, 2024

How can I configure npm to use that branch while not merged?

@timestep
Copy link

+1

@OskarPersson
Copy link

@dangreen @igorlukanin

@dangreen
Copy link
Collaborator

#1230 (comment)

@dangreen
Copy link
Collaborator

@anajavi Hi. Please rebase PR

@anajavi
Copy link
Contributor Author

anajavi commented Dec 31, 2024

@dangreen I've rebased this

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 8.85%. Comparing base (4b3e718) to head (ebe188d).

Files with missing lines Patch % Lines
sandboxes/chart/events/App.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1236   +/-   ##
======================================
  Coverage    8.85%   8.85%           
======================================
  Files          57      57           
  Lines        1897    1897           
  Branches       24      24           
======================================
  Hits          168     168           
  Misses       1729    1729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dangreen
Copy link
Collaborator

@anajavi Please fix issues with types

@anajavi
Copy link
Contributor Author

anajavi commented Dec 31, 2024

@dangreen test typings should be fixed now

@dangreen dangreen merged commit 055b601 into reactchartjs:master Jan 1, 2025
6 checks passed
@dangreen
Copy link
Collaborator

dangreen commented Jan 1, 2025

https://github.com/reactchartjs/react-chartjs-2/releases/tag/v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: React 19 not added as a peer dependency React 19 Support
7 participants