New Features and Fixes #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added debounce Update styles
Infinite scroller fixes
Removed tape and added jest for testing Updated unit tests Clean up fetch calls, smaller and cleaner code
Update tests
Clean up code Remove unwanted styles, since custom styles are now supported
Move api call to componentDidMount
|
@StevenIseki Hey, any concerns regarding the PR? |
Signed-off-by: Arjun Komath <[email protected]>
Signed-off-by: Arjun Komath <[email protected]>
Publish to npm
Use a two column grid layout instead on a single column Signed-off-by: Arjun Komath <[email protected]>
Fix warning for react while setting height of image Signed-off-by: Arjun Komath <[email protected]>
|
Hey @arjunkomath sorry I was a bit busy for awhile there and wasn't working on this component. I have updated the component to use react 16 and latest versions of babel, webpack for the build. I am very interested in your help on the following features you worked on.
If you don't have time, I can work on these based on your work in this pr and can add you as a collaborator. Thanks a lot for all your great work on this! |
|
Hey @StevenIseki I will work on some of the features 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@StevenIseki If you would like to keep v1 as is, we could move v1 to separate branch, merge this PR to master and publish it as v2.