Fix Grid items/content alignment when just a single value is set (#569)
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedrich-schindler
approved these changes
Oct 4, 2024
adamkudrna
force-pushed
the
fix/grid-alignment
branch
from
9af02ba to
3393106
Compare
bedrich-schindler
approved these changes
Oct 7, 2024
Intentionally use longhand properties because the custom property fallback mechanism evaluates `initial` values as empty. That makes the other value of the shorthand property unexpectedly used for both axes.
adamkudrna
force-pushed
the
fix/grid-alignment
branch
from
3393106 to
dc3cf0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally use longhand properties because custom property fallback mechanism evaluates
initialvalues as empty. That makes the other value of the shorthand property unexpectedly used for both axes.Introduced in #550. Closes #569.