-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering glitch of Popover
arrow on low-dpi displays
#559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! I'd like to ask for a few minor adjustments to improve code readability and keep the existing flexibility (rem units).
The PR name could be like "Fix rendering glitch of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this took me some time to figure out, but I think I found the right calculations for what we need. You can test it with various values, for example 2 px gap and 8 px overlap or whatsoever.
Popover
arrow on low-dpi displays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! 🎉
33a9195
to
ed04de4
Compare
ed04de4
to
e1bb6cc
Compare
Because of rendering quirks sometimes a line can appear between the popover and arrow
(more visible on low dpi displays)
This pr fixes that by moving the arrow 1px down