Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow form fields' label to accept any node (#526) #543

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

bedrich-schindler
Copy link
Contributor

Closes #526

@bedrich-schindler
Copy link
Contributor Author

Documentation does not specifically mention data type of labels, only in the props table. @adamkudrna @mbohal @dacerondrej, do you think we need to extend documentation of those components to mention this possibility or not? Personally, I do not see any additional value to this.

I expect to extend documentation of Popover to mention possibility to extend label with Popover (#489), but do not know what to say about it in documentation of inputs ...

src/components/CheckboxField/CheckboxField.jsx Outdated Show resolved Hide resolved
src/components/CheckboxField/CheckboxField.jsx Outdated Show resolved Hide resolved
@bedrich-schindler bedrich-schindler requested a review from mbohal June 6, 2024 05:41
@adamkudrna adamkudrna changed the title Change label of inputs to accept any node (#526) Allow form fields' label to accept any node (#526) Jul 31, 2024
@adamkudrna adamkudrna merged commit 698101c into master Jul 31, 2024
11 checks passed
@adamkudrna adamkudrna deleted the feature/526 branch July 31, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass label as node into form elements
4 participants