-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forgotten console log in dev mode #533
Fix forgotten console log in dev mode #533
Conversation
Thank you for the PR. In regards of 48697e4
In regards of 62d06cb The commit message in inaccurate. I think plain: "Remove forgotten Also please see: https://github.com/react-ui-org/react-ui/blob/master/CONTRIBUTING.md#git-workflow. Specifically:
I added tag to the PR so it will be included in the correct section in Changelog upon release. Normally this is detected from branch name, but for that to work the name would have to be |
Hey, I've disabled all sorts of console log messages including the console.error one which i previously allowed. Regarding the commit messages, do you want me to edit the previous ones or is it okay if it is as it is. I can merge all the commits into one and then add a new commit message if you want me to! Btw, Thanks for helping me out |
Generally we strive for well documented atomic commits. I think it forces one to write better code, allows for easier code review and makes it quicker to find something in project history when needed. This PR however is so small and simple, that I think it is fine to squash all commits into on with the commit message "Forbid |
95bb479
to
632959e
Compare
Squashed all commits into a single commit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The tests are failing: Could you please add The tests can be run locally by Thank you very much, your effort is greatly appreciated. Sorry I did not mention it before, but I only realized when I run the tests on GH. |
@joeyyy09 looks good! As a last thing, could you please squash all the commits together? I tried to do it when merging, but GH dopes not seem to allow it here. |
Signed-off-by: Joeyyy09 <[email protected]>
ec07526
to
7491ba2
Compare
Yeah, done! Thanks for being so patient out with this! |
This goes both ways. I was afraid I was being to picky. Thanks again and if you feel like submitting any more PRs we would be very grateful. |
PR Description:
Changes Made:
Removed the console.log statement from the codebase to improve code cleanliness and prevent unnecessary logging. Additionally, added a linting rule to disallow console.log statements unless explicitly allowed by an eslint-disable statement.
Reasoning:
Removing console.log statements helps maintain a clean codebase and prevents clutter in the console output. By enforcing a linting rule to disallow console.log statements, we ensure consistency in code quality and adherence to best practices.
Impact:
Enhances code readability and maintainability by removing unnecessary logging statements.
Helps prevent accidental logging of sensitive information in production environments.
Encourages developers to use more robust debugging techniques, such as using breakpoints or logging to a dedicated debugging tool.
Related Issue:
This PR addresses issue #532. Link to issue