-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit link to legacy list of React synthetic events in component documentation #519
Conversation
bacd21a
to
02c8215
Compare
It's not just the Also I'm unsure if we can omit such a basic thing as the What does @bedrich-schindler think?
I could not find this in the PR… |
@adamkudrna I chnaged the wording to include a reference to both the MDN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! This is much more helpful. 👏🏻
In the end I arranged links to resources as a list because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful job, thank you! 👏🏻
12d4088
to
12171e1
Compare
The page listing react synthetic events became legacy and was moved to https://legacy.reactjs.org/docs/events.html
I could not find a direct replacement, the closes thing I found is https://react.dev/reference/react-dom/components/common#common-props. This page however is not HTML element specific and thus I think it better to link do MDN even though there some differences (e.g.
class
vsclassName
)Also I have updated transferProps based on the new doc page.