Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mkDocs CSS and JS resource calls from template to config #508

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

adamkudrna
Copy link
Member

Config seems to be the better place — unless we need the additional <script> attributes like crossorigin or type. @mbohal Do we need them? There is no warning in console and everything seems to be working.

@adamkudrna adamkudrna requested a review from mbohal October 30, 2023 17:26
@adamkudrna adamkudrna self-assigned this Oct 30, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 30, 2023
@adamkudrna adamkudrna merged commit 1154d8f into master Nov 13, 2023
11 checks passed
@adamkudrna adamkudrna deleted the docs/css-and-js-config branch November 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants