Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Radio and InputGroup in horizontal FormLayout in Chrome and Edge (#493) #498

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

adamkudrna
Copy link
Member

Subgrid is now supported in all major browsers including Chrome and Edge joining as last in August's version 117. However, there is some fieldset/legend magic that prevents subgrid from being used on <fieldset> element (as per the spec (sic!), the magic adds an additional virtual box which breaks the subgrid).

As a result, subgrid cannot be used on <fieldset> elements until the following Chromium issue is resolved:

https://bugs.chromium.org/p/chromium/issues/detail?id=1473242

Closes #493

@adamkudrna adamkudrna self-assigned this Sep 29, 2023
@github-actions github-actions bot added the bug Something isn't working label Sep 29, 2023
… Edge (#493)

Subgrid is now supported in all major browsers including Chrome and Edge joining as last in August's version 117. However, there is some fieldset/legend magic that prevents subgrid from being used on `<fieldset>` element (as per the spec (sic!), the magic adds an additional virtual box which breaks the subgrid).

As a result, subgrid cannot be used on `<fieldset>` elements until the following Chromium issue is resolved:

https://bugs.chromium.org/p/chromium/issues/detail?id=1473242
@adamkudrna adamkudrna force-pushed the bugfix/subgrid-in-chrome branch from 0fc6f86 to 3a17e5b Compare September 29, 2023 10:33
@adamkudrna adamkudrna requested review from mbohal, bedrich-schindler and a team September 29, 2023 10:39
@adamkudrna adamkudrna merged commit fac60f3 into master Oct 2, 2023
10 checks passed
@adamkudrna adamkudrna deleted the bugfix/subgrid-in-chrome branch October 2, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio breaks <FormLayout fieldLayout="horizontal">
2 participants