Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CSS and JS endpoints to use hyphenation #490

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Rename CSS and JS endpoints to use hyphenation #490

merged 1 commit into from
Sep 20, 2023

Conversation

adamkudrna
Copy link
Member

  • Use hyphenation in react-ui because we use it everywhere.
  • Rename cssCustomProperties endpoint to docsCustomProperties so it's clear what is it for.

@adamkudrna adamkudrna requested a review from mbohal as a code owner September 18, 2023 15:10
@adamkudrna adamkudrna self-assigned this Sep 18, 2023
@adamkudrna adamkudrna added the skip changelog Pull request will be excluded from change log label Sep 18, 2023
@adamkudrna adamkudrna requested a review from a team September 18, 2023 15:21
mbohal
mbohal approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mbohal mbohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it, but it looks OK.

@adamkudrna adamkudrna merged commit 5be595c into master Sep 20, 2023
11 checks passed
@adamkudrna adamkudrna deleted the refactoring/bundle-names branch September 20, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacerondrej dacerondrej dacerondrej approved these changes

@bedrich-schindler bedrich-schindler bedrich-schindler approved these changes

@mbohal mbohal mbohal approved these changes

Assignees

@adamkudrna adamkudrna

Labels
refactoring skip changelog Pull request will be excluded from change log
Projects
The Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamkudrna @mbohal @bedrich-schindler @dacerondrej