Split color prop test by collections

react-ui-org · Sep 11, 2024 · c41f5ed · c41f5ed
1 parent 5bcecab
commit c41f5ed
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 17 deletions.
diff --git a/src/components/Alert/__tests__/Alert.test.jsx b/src/components/Alert/__tests__/Alert.test.jsx
@@ -5,7 +5,8 @@ import {
   within,
 } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import { colorPropTest } from '../../../../tests/propTests/colorPropTest';
+import { feedbackColorPropTest } from '../../../../tests/propTests/feedbackColorPropTest';
+import { neutralColorPropTest } from '../../../../tests/propTests/neutralColorPropTest';
 import defaultTranslations from '../../../translations/en';
 import { Alert } from '../Alert';
 
@@ -20,7 +21,8 @@ describe('rendering', () => {
       { children: <div>content text</div> },
       (rootElement) => expect(within(rootElement).getByText('content text')),
     ],
-    ...colorPropTest,
+    ...feedbackColorPropTest,
+    ...neutralColorPropTest,
     [
       { icon: (<div>icon</div>) },
       (rootElement) => expect(within(rootElement).getByText('icon')),

diff --git a/src/components/Badge/__tests__/Badge.test.jsx b/src/components/Badge/__tests__/Badge.test.jsx
@@ -3,7 +3,8 @@ import {
   render,
   within,
 } from '@testing-library/react';
-import { colorPropTest } from '../../../../tests/propTests/colorPropTest';
+import { feedbackColorPropTest } from '../../../../tests/propTests/feedbackColorPropTest';
+import { neutralColorPropTest } from '../../../../tests/propTests/neutralColorPropTest';
 import { Badge } from '../Badge';
 
 const mandatoryProps = {
@@ -12,7 +13,8 @@ const mandatoryProps = {
 
 describe('rendering', () => {
   it.each([
-    ...colorPropTest,
+    ...feedbackColorPropTest,
+    ...neutralColorPropTest,
     [
       { label: 'label text' },
       (rootElement) => expect(within(rootElement).getByText('label text')),

diff --git a/src/components/Button/__tests__/Button.test.jsx b/src/components/Button/__tests__/Button.test.jsx
@@ -7,7 +7,8 @@ import {
 import userEvent from '@testing-library/user-event';
 import { actionColorPropTest } from '../../../../tests/propTests/actionColorPropTest';
 import { blockPropTest } from '../../../../tests/propTests/blockPropTest';
-import { colorPropTest } from '../../../../tests/propTests/colorPropTest';
+import { feedbackColorPropTest } from '../../../../tests/propTests/feedbackColorPropTest';
+import { neutralColorPropTest } from '../../../../tests/propTests/neutralColorPropTest';
 import { refPropTest } from '../../../../tests/propTests/refPropTest';
 import { labelPropTest } from '../../../../tests/propTests/labelPropTest';
 import { sizePropTest } from '../../../../tests/propTests/sizePropTest';
@@ -67,7 +68,8 @@ describe('rendering', () => {
     ],
     ...actionColorPropTest,
     ...blockPropTest,
-    ...colorPropTest,
+    ...feedbackColorPropTest,
+    ...neutralColorPropTest,
     [
       { disabled: true },
       (rootElement) => expect(rootElement).toBeDisabled(),

diff --git a/src/components/Card/__tests__/Card.test.jsx b/src/components/Card/__tests__/Card.test.jsx
@@ -3,7 +3,8 @@ import {
   render,
   within,
 } from '@testing-library/react';
-import { colorPropTest } from '../../../../tests/propTests/colorPropTest';
+import { feedbackColorPropTest } from '../../../../tests/propTests/feedbackColorPropTest';
+import { neutralColorPropTest } from '../../../../tests/propTests/neutralColorPropTest';
 import { raisedPropTest } from '../../../../tests/propTests/raisedPropTest';
 import { ScrollView } from '../../ScrollView';
 import { Card } from '../Card';
@@ -33,7 +34,8 @@ describe('rendering', () => {
       { children: <ScrollView>scroll view content</ScrollView> },
       (rootElement) => expect(within(rootElement).getByText('scroll view content')),
     ],
-    ...colorPropTest,
+    ...feedbackColorPropTest,
+    ...neutralColorPropTest,
     ...densePropTest('Root'),
     [
       { disabled: true },

diff --git a/tests/propTests/colorPropTest.js → tests/propTests/feedbackColorPropTest.js b/tests/propTests/colorPropTest.js → tests/propTests/feedbackColorPropTest.js
@@ -1,8 +1,4 @@
-export const colorPropTest = [
-  [
-    { color: 'dark' },
-    (rootElement) => expect(rootElement).toHaveClass('isRootColorDark'),
-  ],
+export const feedbackColorPropTest = [
   [
     { color: 'danger' },
     (rootElement) => expect(rootElement).toHaveClass('isRootColorDanger'),
@@ -15,10 +11,6 @@ export const colorPropTest = [
     { color: 'info' },
     (rootElement) => expect(rootElement).toHaveClass('isRootColorInfo'),
   ],
-  [
-    { color: 'light' },
-    (rootElement) => expect(rootElement).toHaveClass('isRootColorLight'),
-  ],
   [
     { color: 'note' },
     (rootElement) => expect(rootElement).toHaveClass('isRootColorNote'),

diff --git a/tests/propTests/neutralColorPropTest.js b/tests/propTests/neutralColorPropTest.js
@@ -0,0 +1,10 @@
+export const neutralColorPropTest = [
+  [
+    { color: 'dark' },
+    (rootElement) => expect(rootElement).toHaveClass('isRootColorDark'),
+  ],
+  [
+    { color: 'light' },
+    (rootElement) => expect(rootElement).toHaveClass('isRootColorLight'),
+  ],
+];