Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make showTitle work for sizeChanger #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhiyuc123
Copy link

@zhiyuc123 zhiyuc123 commented Jan 22, 2022

close #370

@vercel
Copy link

vercel bot commented Jan 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/HTAHxJTmZoFz1i2WaQSVXFkEAPJu
✅ Preview: https://pagination-git-fork-zhiyuc123-bugfixshowtitle-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #372 (3cd199e) into master (04b57e6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   92.66%   92.69%   +0.02%     
==========================================
  Files           3        3              
  Lines         341      342       +1     
  Branches      119      120       +1     
==========================================
+ Hits          316      317       +1     
  Misses         25       25              
Impacted Files Coverage Δ
src/Pagination.jsx 91.41% <ø> (ø)
src/Options.jsx 98.46% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b57e6...3cd199e. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jan 24, 2022

ci failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

showTitle prop should also work for sizeChanger
2 participants