Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:dynamic mention options do not always load #36

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

Gylllll
Copy link
Contributor

@Gylllll Gylllll commented Sep 24, 2020

#36

问题复现:

按下 shift ,再按下 @

此时分两种情况:

  1. 先抬起 @ ,再抬起 shift ,则可以正常显示选项
  2. 反之,先抬起 shift ,再抬起 @ ,则无法显示选项

期望:无论先抬起@,还是先抬起shift,都应正常显示选项

已解决该问题

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #36 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files           6        6           
  Lines         228      229    +1     
  Branches       50       51    +1     
=======================================
+ Hits          226      227    +1     
  Misses          2        2           
Impacted Files Coverage Δ
src/Mentions.tsx 99.28% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41db3a...1ef214c. Read the comment docs.

@afc163 afc163 merged commit 4be3825 into react-component:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants