Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interview): Rewrite interview using React and Redux [0] #941

Merged
merged 72 commits into from
Dec 6, 2024

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Mar 12, 2024

This PR will add a new React/Redux based interview, which replaces project_questions. It will also remove the vendor file system and django-compressor/SASS. So far the following changes are implemented:

  • Add project_interview view
  • Refactor webpack config

This PR is the first part of the big React/Redux based refactoring of the interview. It contains the following changes:

CHANGELOG.md will be updated at the end to not complicate things further.

@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Mar 12, 2024
@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 91.563% (-0.03%) from 91.591%
when pulling 4878a6a on interview
into c945d7d on main.

@jochenklar jochenklar requested a review from CalamityC May 2, 2024 10:30
@jochenklar jochenklar self-assigned this May 14, 2024
rdmo/core/assets/js/components/Modal.js Outdated Show resolved Hide resolved
rdmo/core/assets/js/hooks/useModal.js Outdated Show resolved Hide resolved
rdmo/core/assets/js/utils/lang.js Show resolved Hide resolved
@jochenklar jochenklar changed the base branch from main to 2.3.0 August 25, 2024 12:05
@jochenklar jochenklar force-pushed the interview branch 2 times, most recently from 93fd332 to a211464 Compare August 25, 2024 14:00
@jochenklar jochenklar changed the title Rewrite interview using React and Redux feat(interview): Rewrite interview using React and Redux [0] Dec 3, 2024
@jochenklar jochenklar marked this pull request as ready for review December 5, 2024 11:23
@jochenklar jochenklar requested a review from MyPyDavid December 5, 2024 11:24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to Breadcrumb.js ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do so at the end.

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the work!

@jochenklar jochenklar merged commit 612c989 into 2.3.0 Dec 6, 2024
19 checks passed
@jochenklar jochenklar deleted the interview branch December 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants