-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update python dependencies #693
chore: update python dependencies #693
Conversation
caf8621
to
c57a17f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d121c50
to
6ce0304
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6ce0304
to
fc5a089
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fc5a089
to
37b1c9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
5b4a087
to
ea0894d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
It's done. 🥳 ... but actually Django 5.0 is coming soon. |
This comment was marked as resolved.
This comment was marked as resolved.
Thank you, glad I could help out. |
25ed8a9
to
68194cb
Compare
I adopted your requested changes. Happy if you review again. |
] | ||
|
||
[project.optional-dependencies] | ||
allauth = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new optional dependency group you asked for.
@@ -29,6 +29,10 @@ | |||
'allauth.account' | |||
] | |||
|
|||
MIDDLEWARE += [ | |||
'allauth.account.middleware.AccountMiddleware' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test config using allauth in installed apps needs this middleware to run, otherwise django will not even start.
pyproject.toml
Outdated
ci = [ | ||
"coveralls", | ||
"coveralls~=3.3", | ||
"rdmo[allauth]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have allauth available in CI for the tests, so I added the new group here as well.
"psycopg2-binary~=2.9.6", | ||
# once python 3.12 is officially released, the psycopg team will release a psycopg-binary for it. | ||
# replace these two lines with "psycopg[binary]~=3.1" | ||
"psycopg[binary]~=3.1; python_version<'3.12'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.8 - 3.11 with Django 4.2 can utilize psycopg3, i.e. psycopg[binary].
There will be a binary available, when Python 3.12 is officially released. I will adapt accordingly in October.
This comment was marked as resolved.
This comment was marked as resolved.
Ah sorry, I merged the other two PR into |
I will rebase. |
c063ef7
to
1729b8c
Compare
Branch is rebased, the tests still passing. |
Thanks. In principle I can merge now. One last question, are you sure that pinning to |
I think it is a good idea for most libraries that use semantic versioning. django-allauth being 0.* could potentially break something anytime. But I think it might be better to be forgiving here and pin later? The CI and dependabot should catch something breaking, right? You can decide if you prefer pinning Django==4.2.5, Django~=4.2.5 or Django~=4.2. I would suggest the last one. Maybe with pinning all dependencies that have v0? What do you think? Otherwise of course add the patch versions to the toml file. |
Ok, I will review the dependencies later. I think a good compromise is to allow for a minor version change unless the major version is 0. Thanks again. |
…encies chore: update python dependencies
Proposed Changes
This PR proposed the following changes:
MembershipDeleteView.delete()
toMembershipDeleteView.form_valid()
, fixes DeleteViewCustomDeleteWarningProfileForm
, when an unsaved user model instance was used in a related models lookupIntegrationForm
, when an unsaved integration model instance was used in a related models lookupRelated issue: #442
Packages to be updated
Progress
Notes
pytest rdmo/core/tests/test_swagger.py --nomigrations -s -rw
Django Deprecation Timeline