Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: gh #154 : Upgrading autogenerate script to generate weak stubs #159

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

kanjoe24
Copy link
Contributor

Changes done to make all stubs in skeleton/src as weak.
Also done changes for the src file have (c) header.

@kanjoe24 kanjoe24 requested a review from a team as a code owner December 12, 2024 12:40
@rdkcmf-jenkins
Copy link

b'## Copyright scan failure
Commit: 7fb879d
Report detail: https://gist.github.com/rdkcmf-jenkins/4d79c11ad0dd4b2033f6dc6744f2c85d'

Changes done to make all stubs in skeleton/src as weak.
Also done changes for the src file have correct headers.
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch from 7fb879d to 588fb63 Compare December 12, 2024 12:45
@kanjoe24 kanjoe24 self-assigned this Dec 12, 2024
@kanjoe24 kanjoe24 added the enhancement New feature or request label Dec 12, 2024
@kanjoe24 kanjoe24 linked an issue Dec 12, 2024 that may be closed by this pull request
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch 3 times, most recently from e713ce1 to 3b1f734 Compare December 13, 2024 16:18
@kanjoe24 kanjoe24 requested a review from Ulrond December 13, 2024 16:20
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch 2 times, most recently from 47c13c1 to 6d2d7e1 Compare December 13, 2024 17:17
@kanjoe24
Copy link
Contributor Author

The makefile was tested with attached changes on hdmi cec test suite and worked fine.
ut-changes.diff.txt

@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch from 6d2d7e1 to 6baa470 Compare December 13, 2024 17:24
Copy link
Contributor

@Ulrond Ulrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes required.

Makefile Outdated Show resolved Hide resolved
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch 2 times, most recently from 246491b to f89d8dd Compare December 16, 2024 16:17
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch 2 times, most recently from 67ebffb to 59fc3fe Compare December 16, 2024 16:45
@kanjoe24
Copy link
Contributor Author

Results from ./release-test-script-ut-core.sh

 ./release-test-script-ut-core.sh -t feature/gh154-upgrade-autogeneration-script
UT_CORE_BRANCH_NAME = feature/gh154-upgrade-autogeneration-script
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==========================================================
RESULTS for ubuntu 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================

@kanjoe24
Copy link
Contributor Author

Results from ./release-test-script-platform.sh -t feature/gh154-upgrade-autogeneration-script, with ./build_ut.sh TARGET=linux on linux and ./buid_ut.sh TARGET=arm on arm

==========================================================
RESULTS for ubuntu 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-ubuntu
Hal binary does not exist. FAIL 
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-VM-SYNC
Hal binary does not exist. FAIL 
CURL static lib does not exist. FAIL 
Openssl static lib does not exist. FAIL 
CMake host binary does not exist. FAIL 
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_arm
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for dunfell_linux 
Branch is not switched. FAIL
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_linux
Hal binary does not exist. FAIL 
CURL static lib does not exist. PASS 
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_arm
Hal binary does not exist. FAIL 
CURL static lib does not exist. FAIL 
Openssl static lib does not exist. FAIL 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_linux 
Branch is not switched. FAIL
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_linux
Hal binary does not exist. FAIL 
CURL static lib does not exist. FAIL 
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================

Results from ./release-test-script-platform.sh -t feature/gh154-upgrade-autogeneration-script, with ./build_ut.sh in linux and ./buid_ut.sh TARGET=arm on arm

./release-test-script-platform.sh -t feature/gh154-upgrade-autogeneration-script
UT_CORE_BRANCH_NAME = feature/gh154-upgrade-autogeneration-script
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==========================================================
RESULTS for ubuntu 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-ubuntu
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-VM-SYNC
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
ut/ut-core/framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_arm
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_linux
ut/bin/hal_test exists. PASS
CURL static lib does not exist. PASS 
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_arm
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_linux
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================

@kanjoe24 kanjoe24 requested a review from Ulrond December 17, 2024 12:46
Makefile Outdated Show resolved Hide resolved
@kanjoe24 kanjoe24 force-pushed the feature/gh154-upgrade-autogeneration-script branch from 59fc3fe to b4e281c Compare December 18, 2024 10:34
@kanjoe24
Copy link
Contributor Author

screenshot for weak stubs created and file header in skeletons created.
Screenshot 2024-12-18 at 10 58 00

@kanjoe24 kanjoe24 requested a review from Ulrond December 18, 2024 11:00
@kanjoe24
Copy link
Contributor Author

release script results

 ./release-test-script-ut-core.sh -t feature/gh154-upgrade-autogeneration-script
UT_CORE_BRANCH_NAME = feature/gh154-upgrade-autogeneration-script
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==========================================================
RESULTS for ubuntu 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh154-upgrade-autogeneration-script
. PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
==========================================================

@kanjoe24
Copy link
Contributor Author

Release script results with ./build_ut.sh for linux and ./build_ut.sh TARGET=arm for arm

 ./release-test-script-platform.sh -t feature/gh154-upgrade-autogeneration-script
UT_CORE_BRANCH_NAME = feature/gh154-upgrade-autogeneration-script
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==========================================================
RESULTS for ubuntu 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-ubuntu
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-VM-SYNC
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
ut/ut-core/framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_arm
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-dunfell_linux
ut/bin/hal_test exists. PASS
CURL static lib does not exist. PASS 
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_arm
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh154-upgrade-autogeneration-script
            . PASS
/home/jpn323/workspace/gh154-upgrade-autogeneration-script/scripts/rdk-halif-hdmi_cec-kirkstone_linux
ut/bin/hal_test exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================

@kanjoe24 kanjoe24 merged commit 38990a0 into develop Dec 18, 2024
3 checks passed
@kanjoe24 kanjoe24 deleted the feature/gh154-upgrade-autogeneration-script branch December 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

Task: Create Stubs as Weak
3 participants