Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reattach source method unified for two tasks #351

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

skywojciechowskim
Copy link
Contributor

Summary: Reattach source method unified for two tasks
Type: Feature
Test Plan: UT/ CT, Fullstack
Jira: RIALTO-635

Copy link

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copy link

tests/unittests/media/client/ipc/mediaPipelineIpc/SourceTest.cpp:69:1: error: The one definition rule is violated, different classes/structs have the same name 'MediaSourceTest' [ctuOneDefinitionRuleViolation]
class MediaSourceTest : public IMediaPipeline::MediaSource
^
tests/unittests/media/server/gstplayer/genericPlayer/common/GenericTasksTestsBase.cpp:199:1: note: The one definition rule is violated, different classes/structs have the same name 'MediaSourceTest'
class MediaSourceTest : public IMediaPipeline::MediaSource
^
tests/unittests/media/client/ipc/mediaPipelineIpc/SourceTest.cpp:69:1: note: The one definition rule is violated, different classes/structs have the same name 'MediaSourceTest'
class MediaSourceTest : public IMediaPipeline::MediaSource
^
tests/componenttests/client/tests/base/MediaPipelineTestMethods.cpp:272:0: style: The function 'attachSourceAudioEacs' is never used. [unusedFunction]

^
tests/componenttests/client/tests/base/MediaPipelineTestMethods.cpp:267:0: style: The function 'attachSourceAudioMp4' is never used. [unusedFunction]

^
tests/componenttests/client/tests/base/MediaPipelineTestMethods.cpp:249:0: style: The function 'shouldAttachAudioSourceEacs' is never used. [unusedFunction]

^
tests/componenttests/client/tests/base/MediaPipelineTestMethods.cpp:244:0: style: The function 'shouldAttachAudioSourceMp4' is never used. [unusedFunction]

^

Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 85.7%
Functions coverage stays unchanged and is: 92.4%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66573/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66579/

Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 85.7%
Functions coverage stays unchanged and is: 92.4%

1 similar comment
Copy link

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 85.7%
Functions coverage stays unchanged and is: 92.4%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66585/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66586/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66587/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/66588/

@skywojciechowskim skywojciechowskim merged commit 3c62692 into master Nov 28, 2024
49 checks passed
@skywojciechowskim skywojciechowskim deleted the RemoveLegacySwitchAudioSource branch November 28, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants