DELIA-65834 : Skipped new mode request #5740
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssitar583 - Pls update CHANGELOG and version for this change. You can increment the patch version. |
|
can you please stop using detach() in this repo. This is unloadable plugins, detach() is not appropriate. We had numerous crashes on shutdown due to people using detach() in this repo. |
|
@npoltorapavlo As part of DELIA-65834,I have just checked whether timer is in progress or not and no new detach calls were added as part of this handling.Those detach() calls were existing one. |
|
@ssitar583 if you read my comment, it does not say you add detach(). It says it's wrong to use detach() in either form |
DELIA-66118: CloudStore improvements
…sistentstore DELIA-66118: PersistentStore improvements
Reason for change: Returning error in case of new mode request thereby avoiding crash. Test Procedure: 1.Set device to any of the modes(WAREHOUSE/EAS/NORMAL) for 30s. 2.During that 30s,again make a request to set the same/different mode again. 3.Check for crashes. Risks: Low Signed-off-by: Soundaryaa Sitaram<[email protected]>
ssitar583
force-pushed
the
main/DELIA-65834
branch
from
b1f1b69 to
b779f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: Crash occurred when timer expired for Previous mode and trying to set the Normal mode and same time curl request trying to process it.Handled synchronization between the new mode curl request as well as setMode request for NORMAL(default) mode.
Test Procedure: 1.Set device to any of the modes(WAREHOUSE/EAS/NORMAL) for 30s.
2.During that 30s,again make a request to set the same/different mode again.
3.Check for crashes.