RDKVREFPLT-1811 : [RPI][DAB] RDK Service displayinfo plugin - width and height support. #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for change: 1. Introduced the SOC_Abstraction.cpp, Kmc.c and Kmc.h files inside the newly added RPI directoy, SOC_Abstraction.cpp file contains the RPI platform specific implementations as same like the Amlogic. We have change the DEFAULT_DEVICE macro value as /dev/dri/card1 instead of /dev/dri/card0 for RPI. Because we have use the /dev/dri/card1 in RPI for Graphics rendering.This only change is differed from Amlogic platform implementations. Test Procedure: Validate with the JSON-RPC curl commands curl -X POST http://127.0.0.1:9998/jsonrpc -d '{ jsonrpc: 2.0,id: 42, method: DisplayInfo.width}' Result: {jsonrpc:2.0,id:42,result:1280} curl -X POST http://127.0.0.1:9998/jsonrpc -d '{ jsonrpc: 2.0,id: 42, method: DisplayInfo.height}' Result: {jsonrpc:2.0,id:42,result:720} Risks: None. Signed-off-by: [email protected]
|
|
|
|
smuthu065
changed the title
|
Raised the RDKDEV Ticket for code review: RDKDEV-1066 - RDKServices: [RPI][DAB] displayinfo plugin - width & height support code review. |
anand-ky
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKDEV Ticket ID for code Review:
https://jira.rdkcentral.com/jira/browse/RDKDEV-1066
Issue Ticket ID:
https://jira.rdkcentral.com/jira/browse/RDKVREFPLT-1811
Reason for change:
Test Procedure:
Validate with the JSON-RPC curl commands
curl -X POST http://127.0.0.1:9998/jsonrpc -d '{ jsonrpc: 2.0,id: 42, method: DisplayInfo.width}' Result: {jsonrpc:2.0,id:42,result:1280}
curl -X POST http://127.0.0.1:9998/jsonrpc -d '{ jsonrpc: 2.0,id: 42, method: DisplayInfo.height}'
Result: {jsonrpc:2.0,id:42,result:720}
Risks: None.
Signed-off-by: [email protected]