rbuscli: use safeclib string functions #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Enable cmake test discovery via gtest_discover_tests. Several tests failed because the test setup relied on a different working directory from the default that ctest will use; the solution was to explicitly specify the working directory to be the cmake build dir (PROJECT_BINARY_DIR)
Permanence-AI-Coder
force-pushed
the
permai-rbuscli-string-modernize
branch
from
0d7fb1e to
486bf1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by @fwph & @jweese. This PR updates string function usage in rbuscli.c to use the
_sfamily of string functions from safeclib. In addition two commits were made by a human (@fwph): the build process was updated to add safeclib as a dependency to rbus, and a small change was made to the unittests CMakeLists.txt to allow gtest integration with cmake to work correctly.on-behalf-of: https://github.com/permanence-ai [email protected]