Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKBDEV-2306: Insufficent RBus message header #222

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luzwcognizant
Copy link

Reason for change:
Sufficient size to be able to display Device.WiFi.DataElements paths

Reason for change:
Sufficient size to be able to display Device.WiFi.DataElements paths
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@meycint
Copy link

meycint commented Oct 18, 2024

This patch doesn't solve the problem. rbus_regDataElements fails with duplicate name error, which is the result of element name check vs MAX_OBJECT_NAME_LENGTH in rbus_addElement. The value is equal to RTMSG_HEADER_MAX_TOPIC_LENGTH which is defined in rtMessageHeader.h. Increasing it will solve the problem.
Using alias instead of indexes may also cause overflow, but trace will be different than above.

@luzwcognizant
Copy link
Author

luzwcognizant commented Oct 18, 2024

This patch doesn't solve the problem. rbus_regDataElements fails with duplicate name error, which is the result of element name check vs MAX_OBJECT_NAME_LENGTH in rbus_addElement. The value is equal to RTMSG_HEADER_MAX_TOPIC_LENGTH which is defined in rtMessageHeader.h. Increasing it will solve the problem. Using alias instead of indexes may also cause overflow, but trace will be different than above.

Thanks for your feedback, increasing that value is the simplest solution but what is a sufficient size to accomodate the paths? That is why I wanted to get rid of that limitation. Thanks

@luzwcognizant luzwcognizant marked this pull request as ready for review October 22, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants