Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow index 0 in tokenchain instance number #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MasLopez
Copy link

This allows token chains to contain an instance number of 0. rbusTable_addRow in rbus.c defines instNum as a pointer to uint32_t. There is no mechanism to prevent an instance number of 0. However, users will not be able to subscribe to tables that have been created with an instance number of 0 due to the check on line 192 of rbus_tokenchain.c.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

@MasLopez MasLopez force-pushed the fix/allow-instance-0 branch from 4781c9d to ec7ae27 Compare December 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants