Update #103: Creation of remote hdmicec client #115
Conversation
TB-1993
force-pushed
the
feature/gh103_create_remote_cec-client
branch
from
db9c508 to
17ffc04
Compare
| @@ -163,41 +162,25 @@ def _splitDeviceSectionsToDicts(self,command_output:str) -> list: | |||
|
|
|||
| def startMonitoring(self, monitoringLog: str, device_type: MonitoringType = MonitoringType.RECORDER) -> None: | |||
There was a problem hiding this comment.
that seems super complex for a param, I would say that's an internal requirement and fixed, not something that should be configured.
| import logging | ||
| from threading import Thread |
There was a problem hiding this comment.
is there no changes to requriements.txt?
There was a problem hiding this comment.
threading is standard library, so we're all good here.
framework/core/logModule.py
Outdated
| @@ -486,4 +489,57 @@ def stepResult(self, result, message): | |||
| message = "[{}]: RESULT : [{}]: {}".format(self.stepNum,resultMessage, message) | |||
| self.step("=====================Step End======================",showStepNumber=False) | |||
| self.stepResultMessage(message) | |||
|
|
|||
|
|
|||
| def logStreamToFile(self, inputStream: IOBase, outFileName: str) -> None: | |||
There was a problem hiding this comment.
huh?
There's no change to logging to support this.
need to revisit the design, doesn't look correct
There was a problem hiding this comment.
I think this is outside of the scope for logModule.
This is an stream input class, that can write to files., I can't see it being related to logModule()
it uses logModule for writing data to logs, nothing todo with the module though, it's a user of logModule()
| Starts monitoring CEC messages with a specified device type. | ||
|
|
||
| Args: | ||
| deviceType (MonitoringType, optional): The type of device to monitor (default: MonitoringType.RECORDER). |
There was a problem hiding this comment.
it's outside of scope of the user of the API to know anything about what's under it, and what type of device you need to control , or how it's monitored.
| device['active source'] = False | ||
| return devices | ||
|
|
||
| def startMonitoring(self, monitoringLog: str, deviceType: MonitoringType=MonitoringType.RECORDER) -> None: |
There was a problem hiding this comment.
don't see any caller to this module? Where is it linked to anything about it?
the module needs to monitor when launched.. it's not an option, it's a requirement for it's usage.
There was a problem hiding this comment.
No you can't monitor and send messages from the same module, monitoring is blocking. So you'd need to decide what you want to do with the device in the test.
|
The new versions of these still have issues, the remoteCECClient isn't consistent due to the implementation of the readUntil in the sshConsole. I'll raise a bug ticket to get this fixed. |
Moved stream handling to it's own module and added a receiveMessage method to hdmiCECController
TB-1993
force-pushed
the
feature/gh103_create_remote_cec-client
branch
from
fc14435 to
f25a966
Compare
|
|
||
| def listDevices(self) -> list: | ||
| self.stop() | ||
| self._console.write(f'echo "scan" | cec-client -s {self.adaptor} -d 1 > cec-test.txt') |
There was a problem hiding this comment.
Writing it to a file is definitely wrong
retries Corrected hdmiController code to consistently use streamToFile's readUnitl method
Created new remote-cec-client hdmi cec controller.
Also added a threaded logging function to allow the logModule to write a continuous log stream out to a file.
closes #107