Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDKBDEV-2733 : Enable -Werror and -Wall in RdkPppManager. #21

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sanjaynayakk
Copy link
Contributor

Reason for change:
Enabling -Werror and -Wall in RdkPppManager.

Test Procedure: Sanity test.
Risks: None.

@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/390ca538429eab4278c79085db3bfbe0

@pradeeptakdas
Copy link

Internal ticket for tracking build and testing https://ccp.sys.comcast.net/browse/RDKCOM-4908

@sanjaynayakk sanjaynayakk changed the title RDKBDEV-2764 : Enable -Werror and -Wall in RdkPppManager. RDKBDEV-2733 : Enable -Werror and -Wall in RdkPppManager. Aug 14, 2024
@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/d66c5b33f795733c999ac57acc9c6f30

Reason for change:
Enabling -Werror and -Wall in RdkPppManager.

Test Procedure: Sanity test.
Risks: None.

Signed-off-by: K Sanjay Nayak <[email protected]>
@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/ac8c1e130270fe55e98b4f2b168d3715

@rdkcmf-jenkins
Copy link

Copy link
Contributor

@kul2241 kul2241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes need to be done on latest recipe file, which have version tag:v1.1.0 and meta-rdk-wan tag: RC1.5.0a

@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/be43d5c797aba3b1b747a2e2301ea145

@kul2241 kul2241 requested a review from scthunderbolt October 17, 2024 09:27
@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/3432fd906c044921735c3a0a5bb80f1d

@scthunderbolt
Copy link
Contributor

scthunderbolt commented Oct 17, 2024

Build is still failing.

| In file included from ../../../../git/source/TR-181/middle_layer_src/pppmgr_dml_plugin_main.c:35:
| ../../../../git/source/PppManager/pppmgr_global.h:47: error: "ANSC_EXPORT_API" redefined [-Werror]
|    47 | #define ANSC_EXPORT_API
|       |
| ../../../../git/source/PppManager/pppmgr_global.h:42: note: this is the location of the previous definition
|    42 | #define ANSC_EXPORT_API                                __declspec(dllimport)
|       |
...
etc.

@sanjaynayakk
Copy link
Contributor Author

Hi @scthunderbolt

Change for those are fixed as per of commit rdkcentral/RdkPppManager@0c5de5d

it's not included in release https://github.com/rdkcentral/RdkPppManager/releases

@sanjaynayakk
Copy link
Contributor Author

I check locally there are some werror added recent commit.. will check and update here.

@sanjaynayakk sanjaynayakk marked this pull request as draft October 21, 2024 06:13
@rdkcmf-jenkins
Copy link

build-rpi4-broadband-kirkstone Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/862a4640514a6c5c909d3cb983fddb01

Copy link
Contributor

@kul2241 kul2241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sky platform getting lots of format error, so we need to add -Wno-format buil flag in cflag too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants