Feature: connect on demand #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-blasz
force-pushed
the
feature/connect-on-demand
branch
from
63787c2 to
1e4cdec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for the application to connect to the endpoint before using Firebolt, in other words, Firebolt will connect when necessary, on the first request. Also, if a disconnection occurs, Firebolt will try to reconnect when needed.
If the application stops using
Firebolt::IFireboltAccessor::Instance().Connect(), it is not be notified about connection changes because connection change listener is provided inConnect(). To avoid that and allows the application to be notified and check status of connection, the following methods have been introduced:RegisterConnectionChangeListener()&UnregisterConnectionChangeListener()IsConnected()Other fixes:
Firebolt::IFireboltAccessor::Instance(): the instance in kept in a single variable:_singleton, additional oneinstancehas been removed