Feat: Native SDK unit tests support framework #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
b'## Copyright scan failure |
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
AdityaKasar
requested changes
Sep 23, 2024
kschrief
requested changes
Sep 25, 2024
| template <typename RESPONSE> | ||
| Firebolt::Error MockResponse(WPEFramework::Core::JSONRPC::Message &message, RESPONSE &response) | ||
| { | ||
| std::cout << "Inside JSON engine MockResponse function" << std::endl; |
There was a problem hiding this comment.
This debug log can be removed.
| // template <typename RESPONSE> | ||
| void MockRequest(const WPEFramework::Core::JSONRPC::Message* message) | ||
| { | ||
| std::cout << "Inside JSON engine MockRequest function" << std::endl; |
There was a problem hiding this comment.
This debug log can be removed.
| @@ -0,0 +1,1087 @@ | |||
| /* | |||
There was a problem hiding this comment.
Please go through and add comments to this file to explain the functionality. I'm looking specifically for:
- Function definitions
- Explanations of major code sections
|
Since this PR is outdated, moved changes to #222 which is based off of latest Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON engine with validator
Temporary mock transport
Dependency updates