fix: Update getSuffix to properly generate native sdk in pipeline #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinshahfws
approved these changes
Aug 26, 2024
kschrief
pushed a commit
that referenced
this pull request
Aug 26, 2024
## [3.1.1-next.3](v3.1.1-next.2...v3.1.1-next.3) (2024-08-26) ### Bug Fixes * Update getSuffix to properly work in pipeline ([#209](#209)) ([16b4e6e](16b4e6e))
|
🎉 This PR is included in version 3.1.1-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kschrief
pushed a commit
that referenced
this pull request
Aug 30, 2024
## [3.1.1](v3.1.0...v3.1.1) (2024-08-30) ### Bug Fixes * Add provider-selection tag to validation schema ([756e88a](756e88a)) * CPP Enum/AnyOf ([#210](#210)) ([eb768fb](eb768fb)) * Quote unsafe property names in languages that support it ([647043d](647043d)) * Return empty config, not null ([f02aadc](f02aadc)) * Update getSuffix to properly work in pipeline ([#209](#209)) ([16b4e6e](16b4e6e))
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The CPP SDK was not generating properly when being ran in the GitHub Actions pipeline. The file that was not generating correctly was
include/firebolt.h. ThegenerateMethods()function inside ofengine.mjsusesstate.destinationto determine a file suffix. For whatever reasonfirebolt.hhas astate.destinationof an entire file path. The problem is that GitHub Actions sometimes uses underscores in their file path such as/home/runner/_work. The existing suffix logic would not parse the file path correctly and cause the template generation forfirebolt.hto break.Fix
A new function called
getSuffix()is introduced. It works in the following way: