Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: adopt CMAKE_INSTALL_<dir> for install locations #347

Merged
merged 6 commits into from
May 23, 2024

Conversation

bramoosterhuis
Copy link
Contributor

@bramoosterhuis bramoosterhuis commented May 18, 2024

When playing around with a multilib environment, I noticed that if our libs are built 64bit, those libs end up in (/usr/lib) aka /usr/lib32. This is caused because we hardcode all the install locations. Let us leverage the use of GNUInstallDirs to dynamically install binaries to the default install locations set by build systems and package generators.

This PR is part of a series of PR's
rdkcentral/Thunder#1604
rdkcentral/ThunderTools#93
rdkcentral/ThunderClientLibraries#257
rdkcentral/ThunderNanoServices#789
rdkcentral/ThunderUI#99
WebPlatformForEmbedded/ThunderNanoServicesRDK#301
WebPlatformForEmbedded/ThunderLibraries#39

@VeithMetro
Copy link
Contributor

@bramoosterhuis are the build Actions failing because the PR to Thunder needs to be merged first or is it perhaps something else? Here is the error:

CMake Error at interfaces/cmake_install.cmake:65 (file):
  file cannot create directory: /wpeframework/proxystubs.  Maybe need
  administrative privileges.
Call Stack (most recent call first):
  cmake_install.cmake:47 (include)

@bramoosterhuis bramoosterhuis force-pushed the development/enhance-cmake-install-locations branch from 5dbec1a to e9eb439 Compare May 23, 2024 12:26
@pwielders pwielders merged commit 2cf0383 into master May 23, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants