Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDolby] Amend JSON-RPC names after tools modification #316

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[IDolby] Amend JSON-RPC names after tools modification #316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50e8d4c
[IDolby] Amend JSON-RPC names after tools modification
sebaszm Jan 4, 2024
a3faea7
Merge branch 'master' into development/idolby_jsonrpc_corrections
pwielders Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion interfaces/IDolby.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,36 +50,41 @@ namespace Exchange {
PASSTHRU,
DOLBYDIGITAL,
DOLBYDIGITALPLUS,
SOUNDMODE_AUTO
SOUNDMODE_AUTO /* @text:Auto */
};

// @event @uncompliant:extended
struct EXTERNAL INotification : virtual public Core::IUnknown {
enum { ID = ID_DOLBY_OUTPUT_NOTIFICATION };

~INotification() override = default;
// @text soundmodechanged @alt:deprecated dolby_audiomodechanged
virtual void AudioModeChanged(const Dolby::IOutput::SoundModes mode, const bool enabled) = 0;
};

virtual uint32_t Register(INotification*) = 0;
virtual uint32_t Unregister(INotification*) = 0;

// @property
// @text dolbyatmossupported @alt:deprecated dolby_atmosmetadata
// @brief Atmos capabilities of Sink
// @return supported: atmos supported or unsupported
virtual uint32_t AtmosMetadata(bool& supported /* @out */) const = 0;

// @property
// @alt:deprecated dolby_soundmode
// @brief Sound Mode - Mono/Stereo/Surround
// @return mode: sound mode
virtual uint32_t SoundMode(Dolby::IOutput::SoundModes& mode /* @out */) const = 0;

// @property
// @text dolbyatmosoutput @alt:deprecated dolby_enableatmosoutput
// @brief Enable Atmos Audio Output
// @param enable: enable/disable
virtual uint32_t EnableAtmosOutput(const bool enable /* @in */) = 0;

// @property
// @text:dolbymode @alt:dolby_mode
// @brief Dolby Mode
// @param mode: dolby mode type
virtual uint32_t Mode(const Dolby::IOutput::Type& mode) = 0;
Expand Down