Smartlink crash fix #1819
Merged
Smartlink crash fix #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7e8c1a7bacd59f3f3169b524b9928f3dd3111218)
pwielders
reviewed
Jan 20, 2025
pwielders
reviewed
Jan 20, 2025
| @@ -1174,6 +1225,21 @@ namespace Thunder { | |||
| class Connection : public LinkType<INTERFACE> { | |||
| private: | |||
| using Base = LinkType<INTERFACE>; | |||
| class EventSubscriber: public Core::Thread { | |||
There was a problem hiding this comment.
Do we really need a thread here ? This will always (per connection) require an 8MB callstack. I thnk you can "reuse" the ResouceMonitor Thread (communication thread) as this is probably just to request a registration ? Or if we need a thread, could we do something to limit it to 1 thread for all Conenction types per process ?
pwielders
reviewed
Jan 20, 2025
| uint32_t retVal = Core::ERROR_UNAVAILABLE; | ||
| Core::JSONRPC::Message response; | ||
| const string parameters("{ \"event\": \"" + eventName + "\", \"id\": \"" + Base::Namespace() + "\"}"); | ||
| auto result = Base::template Invoke<string>(DefaultWaitTime, "register", parameters, response); |
There was a problem hiding this comment.
Oke, synchronous Invoke, so communication thread is not an option :-) Maybe than 1 thread for all processes that have this ?
pwielders
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.