[ProcessContainers] Runtime configurable containers

[sebaszm]

Container runtime is selectable via enum string "lxc", "runc", "crun", "dobby", "awc" in root/configuration/containertype. LXC is the default.

/etc/Thunder/plugins/Messenger.json

{
 "locator":"libThunderMessenger.so",
 "classname":"Messenger",
 "startmode":"Deactivated",
 "configuration":{
  "root":{
   "mode":"Container",
   "configuration": {
     "containertype": "lxc"
   }
  }
 }
}

Each container runtime has separate configuration that is passed to its Initialize(config) method. Initialize() and Deinitialize() replace system-wide Logging() call. Container system configuration has been moved from COM to the runtime implementation (it was specific to LXC). Each runtime can define its own configuration, if any.

/etc/Thunder/config.json

{
 "version":"5.0.0",
  ...
 "processcontainers": {
   "lxc": {
     "logging":"100KB",
     "loggingdir":"/tmp"
   }
 },

The runtime implementations are registering themselves in ContainerAdminstrator via static initialization.

The previously singleton "administrators" of each implementation are turned into producers that create IContainer concrete objects for the ContainerAdminstrator (i.e. the a factory). The BaseAdministrator common codeis removed as the functionality has been taken over by the factory. The ContainerAdminstrator holds the live containers in a ProxyList.

This solution requires southbound interface changes. LXC and runC implementations are adapted along.

[rdkcmf-jenkins]

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

• Protex Server Path: /home/blackduck/github/Thunder/1723/rdkcentral/Thunder

• Commit: 125e8a2

Report detail: gist

[rdkcmf-jenkins]

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

• Upvote reason: OK

• Commit: 125e8a2

[pwielders]

Since you are on a deserved holiday, oke to merge and will pick the comment up in a next cycle ?

[pwielders]

We are working everywhere with Interface pointers everywhere, why are we now using a proxyType around the interface (at the end we can put it in a ProxyTypeContainer, but for the interface it makes it more depending on Thunder features) Can we not simply retunr a IContainer here ?

[pwielders]

Why is the explicit public Container call, here on 69, not also emplacing the container in the _containers list ? It looks like it is done by calling (from the real implementation line 64 ?)

[pwielders]

Never mind figured it out. It is all due to the automatic lifetime management from the ProxyListType<>... If that the administrator holds the last reference it drops the container. Correct ?

[pwielders]

Why not have in this class, the PRODUCER an aggregated member and than announce (CONTAINERTYPE, IContainerProducer& _Producer); Saves you a list with autopointers and new in the administrator and lifetime is guaranteed aligned with the Announce and Revoke.
It is my allergy to visible "new" 's and std::unique_ptr that triggered this deep dive ;-) and potential simple fix to avoid them..

[pwielders]

wil pick up the remarks in the next round. Sebas is on holiday now..