Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests/unit/core] : DataElement improvements #1682

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[Tests/unit/core] : DataElement improvements #1682

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
74bf831
[Tests/unit/core] : Update expectations
msieben Jul 1, 2024
72279fb
[Tests/unit/core] : Add test to 'test_dataelement'
msieben Jul 1, 2024
a753895
[core/DataElement] : Improve 'Shrink' and 'Expand'
msieben Jul 3, 2024
7c3adac
[Tests/unit/core] : 'Improve 'test_dataelement'
msieben Jul 3, 2024
5273de4
[core/DataElement] : improve some conditions
msieben Jul 3, 2024
fc4dd32
[Tests/unit/core] : Add tests to 'test_dataelement'
msieben Jul 3, 2024
6b7a2ff
[core/DataElement] : various improvements
msieben Jul 3, 2024
0007395
Merge branch 'master' into development/dataelement
msieben Jul 3, 2024
f94444d
[core/DataElement] : requested review changes
msieben Jul 8, 2024
a5ef3e3
Merge branch 'master' into development/dataelement
MFransen69 Jul 9, 2024
5147a21
Merge branch 'master' into development/dataelement
msieben Aug 5, 2024
b1e300d
Merge branch 'master' into development/dataelement
msieben Aug 7, 2024
44233a7
Merge branch 'master' into development/dataelement
msieben Sep 5, 2024
e7dd3d8
Merge branch 'master' into development/dataelement
msieben Sep 12, 2024
d02cf02
Merge branch 'master' into development/dataelement
msieben Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Source/core/DataElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,15 @@ namespace Core {
{
ASSERT(IsValid());
ASSERT(buffer != nullptr);
ASSERT(std::numeric_limits<uint64_t>::max() - size >= offset);

// Check if we cross a boundary for the read..
if ((offset + size) <= Size()) {
// Nope, one plain copy !!!
::memmove(buffer, &(Buffer()[offset]), size);
} else {
// If we want to read more than 4Gb ASSERT !!
ASSERT(Size() >= offset);
ASSERT(Size() - offset < 0xFFFFFFFF);

// oops partial read untill we got it all
Expand All @@ -119,13 +121,15 @@ namespace Core {
{
ASSERT(IsValid());
ASSERT(buffer != nullptr);
ASSERT(std::numeric_limits<uint64_t>::max() - size >= offset);

// Check if we cross a boundary for the write..
if ((offset + size) <= Size()) {
// Nope, one plain copy !!!
::memmove(&(Buffer()[offset]), buffer, size);
} else {
// If we want to write more than 4Gb ASSERT !!
ASSERT(Size() >= offset);
ASSERT(Size() - offset < 0xFFFFFFFF);

// oops partial read untill we got it all
Expand Down
Loading