Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Add 'Time' documentation. #1432

Merged
merged 6 commits into from
Nov 22, 2023
Merged

[docs]: Add 'Time' documentation. #1432

merged 6 commits into from
Nov 22, 2023

Conversation

msieben
Copy link
Contributor

@msieben msieben commented Oct 20, 2023

METROL-847

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

PR Preview Action v1.1.1-25-g59e77e4
🛬 Preview removed because the pull request was closed.
2023-11-22 10:57 UTC


```c++
// Local time instead of UTC
Core::Time past(/*year*/ 2023, /*month* 10, /*day*/ 13, /*hours*/ 18, /*minutes*/ 02, /*seconds 0 ,/* milliseconds*/ 0, /*local time*/ true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing / in "/month"

@MFransen69 MFransen69 requested a review from TeknoVenus October 20, 2023 08:33

```c++
// Local time instead of UTC
Core::Time past(/*year*/ 2023, /*month* 10, /*day*/ 13, /*hours*/ 18, /*minutes*/ 02, /*seconds 0 ,/* milliseconds*/ 0, /*local time*/ true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And missing */ in seconds :)


## Date and time conversion options

The external representation of time is a string formatted in a predefined pattern unless a single integer valued element is represented. Such patterns are intrinsically applied for the various conversions methods made available. Among such conversions are the [RFC2311](https://www.rfc-editor.org/rfc/rfc2311) time and date specification, [RFC1036](https://www.rfc-editor.org/rfc/rfc1036) date specification, the [ISO8601]() date and time formats, and, [ANSI](https://webstore.ansi.org/standards/incits/ansiincits301997) date representation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps good to explicitly indicate we have both from and to conversions for these formats

@pwielders pwielders removed their request for review October 31, 2023 08:41
@MFransen69 MFransen69 merged commit df3a4a1 into master Nov 22, 2023
21 checks passed
@MFransen69 MFransen69 deleted the development/docs-time branch November 22, 2023 10:57
pwielders added a commit that referenced this pull request Dec 1, 2023
* Adding a missing Closing of the new messaging redirect feature (#1452)

* Update vscode configs (#1451)

Co-authored-by: Pierre Wielders <[email protected]>

* [docs]: Add 'Time' documentation. (#1432)

* [docs]: Add 'Time' documentation.

METROL-847

* [docs]: Update 'Time' documentation.

METROL-847 and PR-1432

---------

Co-authored-by: Pierre Wielders <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>

* Terminate after signal (#1459)

---------

Co-authored-by: Mateusz Daniluk <[email protected]>
Co-authored-by: Bram Oosterhuis <[email protected]>
Co-authored-by: msieben <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
Co-authored-by: sebaszm <[email protected]>
MFransen69 added a commit that referenced this pull request Dec 15, 2023
* [JSONRPC] Complete the work to handle JSONRPC over COMRPC so WPEFrameworks can be linked together.

* Merge! (#1460)

* Adding a missing Closing of the new messaging redirect feature (#1452)

* Update vscode configs (#1451)

Co-authored-by: Pierre Wielders <[email protected]>

* [docs]: Add 'Time' documentation. (#1432)

* [docs]: Add 'Time' documentation.

METROL-847

* [docs]: Update 'Time' documentation.

METROL-847 and PR-1432

---------

Co-authored-by: Pierre Wielders <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>

* Terminate after signal (#1459)

---------

Co-authored-by: Mateusz Daniluk <[email protected]>
Co-authored-by: Bram Oosterhuis <[email protected]>
Co-authored-by: msieben <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
Co-authored-by: sebaszm <[email protected]>

* [SYNC] Fixes for linux.

* [SYNC] Merging issues resolved..

* [TESTS] Fixes after testing and including the merges!

* [FIXES] Compilation issue resolving.

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update MetaData.h

* Update PluginServer.h

---------

Co-authored-by: Mateusz Daniluk <[email protected]>
Co-authored-by: Bram Oosterhuis <[email protected]>
Co-authored-by: msieben <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
Co-authored-by: sebaszm <[email protected]>
bramoosterhuis pushed a commit to bramoosterhuis/Thunder that referenced this pull request Apr 26, 2024
* [docs]: Add 'Time' documentation.

METROL-847

* [docs]: Update 'Time' documentation.

METROL-847 and PR-1432

---------

Co-authored-by: Pierre Wielders <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
bramoosterhuis added a commit to bramoosterhuis/Thunder that referenced this pull request Apr 26, 2024
* [JSONRPC] Complete the work to handle JSONRPC over COMRPC so WPEFrameworks can be linked together.

* Merge! (rdkcentral#1460)

* Adding a missing Closing of the new messaging redirect feature (rdkcentral#1452)

* Update vscode configs (rdkcentral#1451)

Co-authored-by: Pierre Wielders <[email protected]>

* [docs]: Add 'Time' documentation. (rdkcentral#1432)

* [docs]: Add 'Time' documentation.

METROL-847

* [docs]: Update 'Time' documentation.

METROL-847 and PR-1432

---------

Co-authored-by: Pierre Wielders <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>

* Terminate after signal (rdkcentral#1459)

---------

Co-authored-by: Mateusz Daniluk <[email protected]>
Co-authored-by: Bram Oosterhuis <[email protected]>
Co-authored-by: msieben <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
Co-authored-by: sebaszm <[email protected]>

* [SYNC] Fixes for linux.

* [SYNC] Merging issues resolved..

* [TESTS] Fixes after testing and including the merges!

* [FIXES] Compilation issue resolving.

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update MetaData.h

* Update PluginServer.h

---------

Co-authored-by: Mateusz Daniluk <[email protected]>
Co-authored-by: Bram Oosterhuis <[email protected]>
Co-authored-by: msieben <[email protected]>
Co-authored-by: Wouter Meek <[email protected]>
Co-authored-by: MFransen69 <[email protected]>
Co-authored-by: sebaszm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants