Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThunderShark docs #1422

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Add ThunderShark docs #1422

merged 7 commits into from
Oct 18, 2023

Conversation

sebaszm
Copy link
Contributor

@sebaszm sebaszm commented Oct 5, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

PR Preview Action v1.1.1-25-g59e77e4
🛬 Preview removed because the pull request was closed.
2023-10-18 13:15 UTC

- debugging - inspecting the parameters and return values passed,
- flow analysis - investigating the order of calls and notifications, keeping track of interfaces instance's lifetime.

It can also have an educational value - by showing their internals dissected it lets developers examine how COM frames are built.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also have an educational value by showing their internals dissected. It lets developers examine how COM frames are built.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rephrase a bit? he it after dissected is a bit unexpected..

Copy link
Contributor Author

@sebaszm sebaszm Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there should've been a colon instead of a pause... "by showing their internals dissected it lets developers examine how COM frames are built", I think this is valid English :)

Copy link
Contributor

@pwielders pwielders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't we going to add the presentation you did to this documentation as well?

docs/debugging/thundershark.md Show resolved Hide resolved
@sebaszm
Copy link
Contributor Author

sebaszm commented Oct 13, 2023

Weren't we going to add the presentation you did to this documentation as well?

This text has already all the details from the presentation in. It's missing the pictures, but I dind't want to bloat this w jpegs.

@pwielders pwielders self-requested a review October 13, 2023 16:08
@pwielders pwielders merged commit e7806c4 into master Oct 18, 2023
5 checks passed
@pwielders pwielders deleted the development/thundershark-docs branch October 24, 2023 15:18
bramoosterhuis pushed a commit to bramoosterhuis/Thunder that referenced this pull request Apr 26, 2024
* Add ThunderShark docs

* Update thundershark.md

* Update thundershark.md

---------

Co-authored-by: Pierre Wielders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants