[WINDOWS] Windows compiler does give different warnings, lets fix tho… (

#1646) * [WINDOWS] Windows compiler does give different warnings, lets fix those as well.. * Update Config.h * Update Configuration.h --------- Co-authored-by: MFransen69 <[email protected]>
rdkcentral · Jun 17, 2024 · 431ba5a · 431ba5a
1 parent f0122a3
commit 431ba5a
Show file tree

Hide file tree

Showing 26 changed files with 98 additions and 104 deletions.
diff --git a/Source/Thunder/Config.h b/Source/Thunder/Config.h
@@ -136,7 +136,7 @@ namespace PluginHost {
                     Add(_T("value"), &Value);
                     Add(_T("override"), &Override);
                 }
-                Environment(Environment&& move)
+                Environment(Environment&& move) noexcept
                     : Core::JSON::Container()
                     , Key(std::move(move.Key))
                     , Value(std::move(move.Value))
@@ -155,7 +155,7 @@ namespace PluginHost {
 
                     return (*this);
                 }
-                Environment& operator=(Environment&& move)
+                Environment& operator=(Environment&& move) noexcept
                 {
                     if (this != &move) {
                         Key = std::move(move.Key);
@@ -210,7 +210,7 @@ namespace PluginHost {
                     Add(_T("stacksize"), &StackSize);
                     Add(_T("umask"), &Umask);
                 }
-                ProcessSet(ProcessSet&& move)
+                ProcessSet(ProcessSet&& move) noexcept
                     : Core::JSON::Container()
                     , User(std::move(move.User))
                     , Group(std::move(move.Group))
@@ -244,7 +244,7 @@ namespace PluginHost {
                     return (*this);
                 }
 
-                ProcessSet& operator=(ProcessSet&& move)
+                ProcessSet& operator=(ProcessSet&& move) noexcept
                 {
                     if (this != &move) {
                         User = std::move(move.User);
@@ -295,7 +295,7 @@ namespace PluginHost {
                     Add(_T("type"), &Type);
                     Add(_T("output"), &OutputEnabled);
                 }
-                InputConfig(InputConfig&& move)
+                InputConfig(InputConfig&& move) noexcept
                     : Core::JSON::Container()
                     , Locator(std::move(move.Locator))
                     , Type(std::move(move.Type))
@@ -316,7 +316,7 @@ namespace PluginHost {
                     return (*this);
                 }
 
-                InputConfig& operator=(InputConfig&& move)
+                InputConfig& operator=(InputConfig&& move) noexcept
                 {
                     if (this != &move) {
                         Locator = std::move(move.Locator);
@@ -349,7 +349,7 @@ namespace PluginHost {
                     Add(_T("proxystubpath"), &ProxyStubPath);
                     Add(_T("configpath"), &PluginConfigPath);
                 }
-                Observables(Observables&& move)
+                Observables(Observables&& move) noexcept
                     : Core::JSON::Container()
                     , ProxyStubPath(std::move(move.ProxyStubPath))
                     , PluginConfigPath(std::move(move.PluginConfigPath)) {
@@ -377,7 +377,7 @@ namespace PluginHost {
                 {
                     Add(_T("logging"), &Logging);
                 }
-                ProcessContainerConfig(ProcessContainerConfig&& move)
+                ProcessContainerConfig(ProcessContainerConfig&& move) noexcept
                     : Logging(std::move(move.Logging))
                 {
                     Add(_T("logging"), &Logging);
@@ -389,7 +389,7 @@ namespace PluginHost {
                     Logging = RHS.Logging;
                     return (*this);
                 }
-                ProcessContainerConfig& operator=(ProcessContainerConfig&& move)
+                ProcessContainerConfig& operator=(ProcessContainerConfig&& move) noexcept
                 {
                     if (this != &move) {
                         Logging = std::move(move.Logging;
@@ -416,7 +416,7 @@ namespace PluginHost {
                 {
                     Add(_T("locator"), &Locator);
                 }
-                HibernateConfig(HibernateConfig&& move)
+                HibernateConfig(HibernateConfig&& move) noexcept
                     : Locator(std::move(move.Locator))
                 {
                     Add(_T("locator"), &Locator);
@@ -428,7 +428,7 @@ namespace PluginHost {
                     Locator = RHS.Locator;
                     return (*this);
                 }
-                HibernateConfig& operator=(HibernateConfig&& move)
+                HibernateConfig& operator=(HibernateConfig&& move) noexcept
                 {
                     if (this != &move) {
                         Locator = std::move(move.Locator);

diff --git a/Source/com/Communicator.h b/Source/com/Communicator.h
@@ -83,7 +83,7 @@ namespace RPC {
             , _configuration(copy._configuration)
         {
         }
-        Object(Object&& move)
+        Object(Object&& move) noexcept
             : _locator(std::move(move._locator))
             , _className(std::move(move._className))
             , _callsign(std::move(move._callsign))
@@ -151,7 +151,7 @@ namespace RPC {
         }
 
 
-        Object& operator=(Object&& move)
+        Object& operator=(Object&& move) noexcept
         {
             if (this != &move) {
                 _locator = std::move(move._locator);
@@ -297,7 +297,7 @@ namespace RPC {
             , _postMortem(copy._postMortem)
         {
         }
-	Config(Config&& move)
+	Config(Config&& move) noexcept
             : _connector(std::move(move._connector))
             , _hostApplication(std::move(move._hostApplication))
             , _persistent(std::move(move._persistent))

diff --git a/Source/core/ASN1.h b/Source/core/ASN1.h
@@ -63,7 +63,7 @@ namespace Core {
             {
                 AddRef();
             }
-            Buffer(Buffer&& move)
+            Buffer(Buffer&& move) noexcept
                 : _buffer(move._buffer)
             {
                 move._buffer = nullptr;
@@ -82,7 +82,7 @@ namespace Core {
                 }
                 return (*this);
             }
-            Buffer& operator=(Buffer&& move)
+            Buffer& operator=(Buffer&& move) noexcept
             {
                 if (&move != this) {
                     Release();
@@ -163,7 +163,7 @@ namespace Core {
                     , _buffer(copy._buffer)
                 {
                 }
-                Iterator(Iterator&& move)
+                Iterator(Iterator&& move) noexcept
                     : _length(move._length)
                     , _index(move._index)
                     , _buffer(move._buffer)
@@ -183,7 +183,7 @@ namespace Core {
                     _buffer = RHS._buffer;
                     return (*this);
                 }
-                Iterator& operator=(Iterator&& move)
+                Iterator& operator=(Iterator&& move) noexcept
                 {
                     if (this != &move) {
                         _length = move._length;
@@ -319,7 +319,7 @@ namespace Core {
                 ::memcpy(_buffer, copy._buffer, copy._length);
                 _length = copy._length;
             }
-            OID(OID&& move)
+            OID(OID&& move) noexcept
             {
                 ::memcpy(_buffer, move._buffer, move._length);
                 _length = move._length;
@@ -337,7 +337,7 @@ namespace Core {
 
                 return (*this);
             }
-            OID& operator=(OID&& move)
+            OID& operator=(OID&& move) noexcept
             {
                 if (this != &move) {
                     ::memcpy(_buffer, move._buffer, move._length);
@@ -465,7 +465,7 @@ namespace Core {
                 , _length(copy._length)
             {
             }
-            Sequence(Sequence&& move)
+            Sequence(Sequence&& move) noexcept
                 : _buffer(std::move(move._buffer))
                 , _index(move._index)
                 , _length(move._length)
@@ -486,7 +486,7 @@ namespace Core {
 
                 return (*this);
             }
-            Sequence& operator=(Sequence&& move)
+            Sequence& operator=(Sequence&& move) noexcept
             {
                 if (this != &move) {
                     _buffer = std::move(move._buffer);

diff --git a/Source/core/DataElement.h b/Source/core/DataElement.h
@@ -189,7 +189,7 @@ namespace Core {
             , m_MaxSize(RHS.m_MaxSize)
         {
         }
-        inline DataElement(DataElement&& move)
+        inline DataElement(DataElement&& move) noexcept
             : m_Storage(std::move(move.m_Storage))
             , m_Buffer(move.m_Buffer)
             , m_Offset(move.m_Offset)
@@ -248,7 +248,7 @@ namespace Core {
 
             return (*this);
         }
-        inline DataElement& operator=(DataElement&& move)
+        inline DataElement& operator=(DataElement&& move) noexcept
         {
             if (this != &move) {
                 m_Size = move.m_Size;
@@ -800,7 +800,7 @@ namespace Core {
             // Don't set the size bigger than the cummulated one!!!
             ASSERT(offset + size < RHS.LinkedSize());
         }
-        inline LinkedDataElement(LinkedDataElement&& move, const uint64_t offset = 0, const uint64_t size = 0)
+        inline LinkedDataElement(LinkedDataElement&& move, const uint64_t offset = 0, const uint64_t size = 0) noexcept
             : DataElement(move, offset, (offset + size > move.Size() ? 0 : size))
             , m_Next(move.m_Next)
         {
@@ -824,7 +824,7 @@ namespace Core {
 
             return (*this);
         }
-        inline LinkedDataElement& operator=(LinkedDataElement&& move)
+        inline LinkedDataElement& operator=(LinkedDataElement&& move) noexcept
         {
             if (this != &move) {
                 DataElement::operator=(move);

diff --git a/Source/core/FileSystem.h b/Source/core/FileSystem.h
@@ -173,7 +173,7 @@ namespace Core {
             return (*this);
         }
 
-        File& operator=(File&& move)
+        File& operator=(File&& move) noexcept
         {
             if (this != &move) {
                 _name = std::move(move._name);
@@ -803,7 +803,7 @@ POP_WARNING()
             return (*this);
         }
 
-        Directory& operator=(Directory&& move)
+        Directory& operator=(Directory&& move) noexcept
         {
             if (this != &move) {
                 _name = std::move(move._name);

diff --git a/Source/core/IPCMessage.h b/Source/core/IPCMessage.h
@@ -104,7 +104,7 @@ namespace Core {
                 : _data(copy._data)
             {
             }
-            ScalarType(ScalarType<string>&& move)
+            ScalarType(ScalarType<string>&& move) noexcept
                 : _data(std::move(move._data))
             {
             }
@@ -118,7 +118,7 @@ namespace Core {
 
                 return (*this);
             }
-            ScalarType<string>& operator=(ScalarType<string>&& move)
+            ScalarType<string>& operator=(ScalarType<string>&& move) noexcept
             {
                 if (this != &move) {
                     _data = std::move(move._data);

diff --git a/Source/core/ISO639.h b/Source/core/ISO639.h
@@ -57,7 +57,7 @@ namespace Core {
             , m_Index(copy.m_Index)
         {
         }
-        Language(Language&& move)
+        Language(Language&& move) noexcept
             : m_SelectedLanguage(std::move(move.m_SelectedLanguage))
             , m_Index(std::move(move.m_Index))
         {
@@ -74,7 +74,7 @@ namespace Core {
 
             return (*this);
         }
-        Language& operator=(Language&& move)
+        Language& operator=(Language&& move) noexcept
         {
             if (this != &move) {
                 m_SelectedLanguage = std::move(move.m_SelectedLanguage);

diff --git a/Source/core/JSON.h b/Source/core/JSON.h
@@ -506,7 +506,7 @@ namespace Core {
             }
             ~NumberType() override = default;
 
-            NumberType<TYPE, SIGNED, BASETYPE>& operator=(NumberType<TYPE, SIGNED, BASETYPE>&& move)
+            NumberType<TYPE, SIGNED, BASETYPE>& operator=(NumberType<TYPE, SIGNED, BASETYPE>&& move) noexcept
             {
                 _value = std::move(move._value);
                 _set = std::move(move._set);
@@ -2650,7 +2650,7 @@ namespace Core {
 
             ~EnumType() override = default;
 
-            EnumType<ENUMERATE>& operator=(EnumType<ENUMERATE>&& move)
+            EnumType<ENUMERATE>& operator=(EnumType<ENUMERATE>&& move) noexcept
             {
                 _value = std::move(move._value);
                 _state = std::move(move._state);
@@ -3135,7 +3135,7 @@ namespace Core {
 
             ~ArrayType() override = default;
 
-            ArrayType<ELEMENT>& operator=(ArrayType<ELEMENT>&& move)
+            ArrayType<ELEMENT>& operator=(ArrayType<ELEMENT>&& move) noexcept
             {
                 _state = std::move(move._state);
                 _data = std::move(move._data);
@@ -4656,7 +4656,7 @@ namespace Core {
                 return (*this);
             }
 
-            VariantContainer& operator=(VariantContainer&& move)
+            VariantContainer& operator=(VariantContainer&& move) noexcept
             {
                 if (this != &move) {
                     _elements = std::move(move._elements);

diff --git a/Source/core/JSONRPC.h b/Source/core/JSONRPC.h
@@ -65,7 +65,7 @@ namespace Core {
                     Add(_T("message"), &Text);
                     Add(_T("data"), &Data);
                 }
-                Info(Info&& move)
+                Info(Info&& move) noexcept
                     : Core::JSON::Container()
                     , Code(std::move(move.Code))
                     , Text(std::move(move.Text))
@@ -85,7 +85,7 @@ namespace Core {
                     return (*this);
                 }
 
-                Info& operator=(Info&& move)
+                Info& operator=(Info&& move) noexcept
                 {
                     if (this != &move) {
                         Code = std::move(move.Code);
@@ -218,7 +218,7 @@ namespace Core {
                 Add(_T("error"), &Error);
             }
 
-            Message(Message&& move)
+            Message(Message&& move) noexcept
                 : Core::JSON::Container()
                 , JSONRPC(std::move(move.JSONRPC))
                 , Id(std::move(move.Id))
@@ -438,7 +438,7 @@ namespace Core {
                 , _sequence(copy._sequence)
                 , _token(copy._token) {
             }
-            Context(Context&& move)
+            Context(Context&& move) noexcept
                 : _channelId(move._channelId)
                 , _sequence(move._sequence)
                 , _token(std::move(move._token)) {
@@ -464,9 +464,9 @@ namespace Core {
             }
 
         private:
-            const uint32_t _channelId;
-            const uint32_t _sequence;
-            const string _token;
+            uint32_t _channelId;
+            uint32_t _sequence;
+            string _token;
         };
 
         typedef std::function<void(const Context& context, const string& parameters, Core::OptionalType<Core::JSON::Error>&)> CallbackFunction;
@@ -545,7 +545,7 @@ namespace Core {
                     , _info(copy._info, copy._asynchronous)
                 {
                 }
-                Entry(Entry&& move)
+                Entry(Entry&& move) noexcept
                     : _asynchronous(move._asynchronous)
                     , _info(std::move(move._info), move._asynchronous)
                 {
@@ -621,7 +621,7 @@ namespace Core {
                     , _position(copy._position)
                 {
                 }
-                EventIterator(EventIterator&& move)
+                EventIterator(EventIterator&& move) noexcept
                     : _container(move._container)
                     , _index(std::move(move._index))
                     , _position(move._position)
@@ -639,7 +639,7 @@ namespace Core {
 
                     return (*this);
                 }
-                EventIterator& operator=(EventIterator&& move)
+                EventIterator& operator=(EventIterator&& move) noexcept
                 {
                     if (this != &move) {
                         _container = move._container;