Check for CCE IEs in Probe Response / Beacon Mgmt Frames #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tucker Polomik <[email protected]>
Generic way to check if a frame contains an information element ID, given OUI, and OUI subtype. Signed-off-by: Tucker Polomik <[email protected]>
Signed-off-by: Tucker Polomik <[email protected]>
|
|
|
Got the OK to add CCE IE checking for Beacons as well, so moving to Draft state temporarily while that's implemented. |
Hoist frame_contains_cce_ie as a forward from frame_contains_ie for code re-use Pumps event if a beacon frame contains a CCE IE to a DM path Signed-off-by: Tucker Polomik <[email protected]>
tuckerpo-cl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for DPP in the context of EasyMesh so that Enrollee APs can know which channel(s) to send a DPP Presence Announcement Frame on such that the Proxy Agent will hear it.
Note: may also need to do something equivalent for Beacon frames containing CCE IEs, but we've heard that there would be bus limitations if consuming and processing too many management frames, especially something as frequent as beacons. Could anyone elaborate on this potential restriction? Canonically the EasyMesh spec claims that CCE IEs should be embedded into both probes and beacons but this PR only addresses probe responses due to the aforementioned "bus restrictions"Note: parsing of beacon mgmt frames for CCE IEs ought to work once beacon management frames are registered to be sniffed when OneWifi is in STA mode (see: https://github.com/rdkcentral/rdk-wifi-hal/blob/develop/src/wifi_hal_nl80211.c#L6797)
The implementation of beacon frame sniffing for now remains TBD.