-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic media session Changes for AML. #31
base: generic-mediasession
Are you sure you want to change the base?
Generic media session Changes for AML. #31
Conversation
Reason for change: *removed soc dependancy. *Added playready packages. Risks: High. Signed-off-by: fasil kv <[email protected]>
Reason for change: *replaced code. *added pure virtual functions that have not been implemented. Risks: High. Signed-off-by: fasil kv <[email protected]>
MediaSessionExt.cpp
Outdated
@@ -1,16 +1,34 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct header? If the file was taken from elsewhere where it has an RDK header, then this is OK but please append a credit to top level NOTICE:
Copyright 2020 RDK Management
Licensed under the Apache License, Version 2.0
If not, then please use the Metrological header as used elsewhere in this component.
There was a spurious code match as well which I have cleared off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mhughesacn
this is a work in progress changes.
will look into your comment make required changes.
e9676d5
to
d246dfb
Compare
d246dfb
to
96234ab
Compare
25a4dd1
to
18e506f
Compare
No description provided.