feat: allow surface class radius to be overwritten by parent #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhowenstine
requested review from
erautenberg,
anthony9187,
ImCoolNowRight,
soumyaloka,
ctoddy and
cee-money
as code owners
ImCoolNowRight
approved these changes
Oct 29, 2024
ctoddy
approved these changes
Oct 30, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Oct 30, 2024
# [@lightningjs/ui-components-v2.25.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.24.0...@lightningjs/ui-components-v2.25.0) (2024-10-30) ### Bug Fixes * allow withEditItems to work with lazyScroll ([#496](#496)) ([0cf0522](0cf0522)) ### Features * allow surface class radius to be overwritten by parent ([#548](#548)) ([3db0c5c](3db0c5c))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows components extending Surface to override its radius property by implementing a dynamic radius calculation based on component dimensions.
Implementation
Adds a _radius getter that computes the radius using the component's style and dimensions.
Testing
Confirmed all components extending Surface work as expected with the new dynamic radius adjustment.