fix(NavigationManager): adjust isFullyOnScreen and isComponentOnScreen

[erautenberg]

Description

The onScreenEffect in our ColumnContainer and Gallery components was not properly alpha-ing off the rows as they scrolled above and off screen. These adjustments make sure that if a component's parent is animating (specifically inside of a FocusManager), that we use the target transition value to determine if the component is fully on the screen or not, otherwise the isComponentOnScreen will return true, even as a row is sliding partially off screen.

References

Testing

Will need to build and import into IS LUI to confirm it is working as expected in ColumnContainer and Gallery, otherwise you can make a custom story of Rows nested in Columns and add the following as the Column's onScreenEffect

      onScreenEffect: function () {
        if (this.items && this.items.length) {
          this.items.forEach((item, idx) => {
            const alpha =
              item.isFullyOnScreen() || idx >= this.selectedIndex ? 1 : 0;

            if (this.shouldSmooth) {
              item.smooth = { alpha };
            } else {
              item.alpha = alpha;
            }
          });
        }
      }

Automation

Checklist

• all commented code has been removed
• any new console issues have been resolved
• code linter and formatter has been run
• test coverage meets repo requirements
• PR name matches the expected semantic-commit syntax

[svc-lightning-ui-components]

Test Execution Failed.

[svc-lightning-ui-components]

Test Execution Failed.

[arwehrman]

On the Basic story the Button/Tile when focused is slightly hidden at the top. Not related to the changes you made, I think so we could just put a bug ticket in for it.
I created a build of the OS and copied over to IS, tested ColumnContainer, everything works as expected

[arwehrman]

Just need to add the \ mentioned in the comments of Base.mdx

[svc-lightning-ui-components]

Test Execution Failed.

[svc-lightning-ui-components]

Test Execution Failed.

[svc-lightning-ui-components]

Test Execution Passed.

[svc-lightning-ui-components]

🎉 This PR is included in version @lightningjs/ui-components-v2.17.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀