-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow componentConfig props to properly merge with component props #416
Conversation
Test Execution Passed. |
Test Execution Failed. |
WARNING: A Blackduck scan failure has been waivedA prior failure has been upvoted
|
I created a build and pulled it into IS. Everything looks ok but there are a few tests failing. Looks like there all variations of Rail so not sure if this related to your changes or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a yarn build
and copied the dist over to IS LUI and the imageScale
doesn't seem to be applied correctly at all anymore, no matter the theme. In the Tile story in the Xfinity theme, nothing seems to happen when swapping between focus and unfocus when it should be scaling. On the Rail story, if I start on the Xfinity theme, it seems like the first tile in the rail is stuck in the scaled up view, and if I switch to Mosaic, it is still stuck that way as well.
Update: The imageScale in current IS LUI seems totally broken already and is not updating on focus/unfocus. Maybe this was a result of the last update?
Description
Props set in componentConfig are not properly merged and are leaving some style properties when themes are changed at runtime. Also any componentConfig properties should deep merge with properties that are set at the instance level.
References
Ticket
Testing
window.CONTEXT.setTheme({componentConfig:{Tile:{artwork:{style:{imageScale:5,},},style:{paddingYProgress:10,paddingYBetweenContent:10,},},},});
window.CONTEXT.setTheme({componentConfig:{Tile:{artwork:{},style:{paddingYProgress:10,paddingYBetweenContent:10,},},},});
Automation
Checklist