fix: remove applySmooth in button #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhowenstine
requested review from
erautenberg,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Failed. |
ImCoolNowRight
force-pushed
the
fix/focus-manager-first-focused
branch
from
f0088f5 to
04d5421
Compare
|
Test Execution Failed. |
2 similar comments
|
Test Execution Failed. |
|
Test Execution Failed. |
packages/@lightningjs/ui-components/src/mixins/withThemeStyles/index.js
Outdated
Show resolved
Hide resolved
ImCoolNowRight
approved these changes
Nov 17, 2023
|
Test Execution Failed. |
3 similar comments
|
Test Execution Failed. |
|
Test Execution Failed. |
|
Test Execution Failed. |
joshhowenstine
changed the title
anthony9187
approved these changes
Nov 20, 2023
…ow or Column. Add gaurds around withThemeStyles for firstEnable
joshhowenstine
force-pushed
the
fix/focus-manager-first-focused
branch
from
0366674 to
a3b91a0
Compare
soumyaloka
approved these changes
Nov 20, 2023
|
Test Execution Passed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Nov 22, 2023
# [@lightningjs/ui-components-v2.17.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.16.1...@lightningjs/ui-components-v2.17.0) (2023-11-22) ### Bug Fixes * **Button:** support re patching prefix after undefined ([#407](#407)) ([e773c32](e773c32)) * **NavigationManager:** adjust isFullyOnScreen and isComponentOnScreen ([#417](#417)) ([32601bd](32601bd)) * remove applySmooth in button ([#409](#409)) ([d2c29dd](d2c29dd)) * **TabBar:** propogate key press events and emit tabChanged signal ([#406](#406)) ([9f06b81](9f06b81)) * **TitleRow:** alias rowMarginTop to titleMarginBottom ([#404](#404)) ([c2c3eb4](c2c3eb4)) * update Checkbox, Radio, and Toggle style mappings ([#408](#408)) ([1e93576](1e93576)) ### Features * **Button:** only repatch prefix/suffix row if props change ([#410](#410)) ([9297903](9297903))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been observed that when a button is displayed as the first item in a Row or Column and immediately receives focus it sill not display the text or icon for the first item.
Does not work if gains focus right away before this PR
Works with timeout before this PR
References
JIRA Ticket
Testing
This currently was not reproduced in Storybook without a lot of changes. Unfortunatly we might need to test this in flex or another consuming app manually by building an artifact.
Automation
Should not require any changes