fix: update Checkbox, Radio, and Toggle style mappings #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erautenberg
changed the title
erautenberg
requested review from
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Failed. |
1 similar comment
|
Test Execution Failed. |
THoj13
approved these changes
Nov 15, 2023
soumyaloka
approved these changes
Nov 15, 2023
…operties to say icon
…rrect style size, then work inwards
ImCoolNowRight
force-pushed
the
fix/form-component-mappings
branch
from
e4c8ba4 to
62c12b2
Compare
|
Test Execution Failed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Nov 22, 2023
# [@lightningjs/ui-components-v2.17.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.16.1...@lightningjs/ui-components-v2.17.0) (2023-11-22) ### Bug Fixes * **Button:** support re patching prefix after undefined ([#407](#407)) ([e773c32](e773c32)) * **NavigationManager:** adjust isFullyOnScreen and isComponentOnScreen ([#417](#417)) ([32601bd](32601bd)) * remove applySmooth in button ([#409](#409)) ([d2c29dd](d2c29dd)) * **TabBar:** propogate key press events and emit tabChanged signal ([#406](#406)) ([9f06b81](9f06b81)) * **TitleRow:** alias rowMarginTop to titleMarginBottom ([#404](#404)) ([c2c3eb4](c2c3eb4)) * update Checkbox, Radio, and Toggle style mappings ([#408](#408)) ([1e93576](1e93576)) ### Features * **Button:** only repatch prefix/suffix row if props change ([#410](#410)) ([9297903](9297903))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Testing
Navigate to the Checkbox, Radio, and Toggle stories (and Small variants) and confirm all is displaying as expected.
Automation
Checklist