fix: calculated height displayed in the inspector for Button and Tile #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per, LUI-1192 the height of the Button in the inspector is zero. On further inspection of Tile, which also utilizes
get h()
, I figured out that the inspector is not updated unless thethis._h
value is updated and the_updateDimensions
method is triggered.For Button:
I had to balance not wanting to manually set "h" and flipping the "hSetByUser" flag and potentially circumventing style/theme updates from changing the Button's dynamic height.
For Tile:
We needed to retain the original size of the Tile without the Metadata via "innerH" and "_h." The final solution was to tap into
_getRenderHeight
and return the value we want, not automatically assumethis._h
is correct.References
Testing
Automation
Checklist