fix: lock lng core version to avoid bug introduced in 2.12.0 #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THoj13
requested review from
erautenberg,
joshhowenstine,
anthony9187,
ImCoolNowRight,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Failed. |
erautenberg
approved these changes
Nov 8, 2023
ImCoolNowRight
approved these changes
Nov 8, 2023
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Nov 9, 2023
# [@lightningjs/ui-components-v2.16.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.15.1...@lightningjs/ui-components-v2.16.0) (2023-11-09) ### Bug Fixes * lock lng core version to avoid bug introduced in 2.12.0 ([#400](#400)) ([a128329](a128329)) ### Features * **Storybook:** upgrade v7 ([#280](#280)) ([5e39f37](5e39f37))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Nov 9, 2023
# [@lightningjs/ui-components-test-utils-v1.5.0](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-test-utils-v1.4.3...@lightningjs/ui-components-test-utils-v1.5.0) (2023-11-09) ### Bug Fixes * lock lng core version to avoid bug introduced in 2.12.0 ([#400](#400)) ([a128329](a128329)) ### Features * **Storybook:** upgrade v7 ([#280](#280)) ([5e39f37](5e39f37))
|
🎉 This PR is included in version @lightningjs/ui-components-test-utils-v1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading
@lightningjs/coreto version2.12.0results in multiple unit tests timing out and failing inArtwork.test.js. I believe this change in@lightningjs/coreis what resulted in these test failures: rdkcentral/Lightning#508.The failing Artwork unit tests are all awaiting a method that gets triggered from the
txLoadedevent, which seems to now be emitted less times due to the above change. We'll lock the@lightningjs/corein this repo to2.11.0until we've resolved the issues.Testing
yarn.lockfile and do a fresh install with theyarncommandyarn workspace @lightningjs/ui-components test^is prepended to the@lightningjs/coreversion inpackage.jsonfiles and these steps are repeated, version 2.12.0 will be installed and the Artwork tests will fail)Checklist